chore: fix various linter issues

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

Author: susnux

__tests__/files/node.spec.ts

@@ -437,8 +437,10 @@ describe('Sanity checks', () => {
 			mime: 'image/jpeg',
 			owner: 'emma',
 		})
-		// @ts-expect-error wrong type error check
-		expect(() => { file.size = 'test' }).toThrowError('Invalid size type')
+		expect(() => {
+			// @ts-expect-error wrong type error check
+			file.size = 'test'
+		}).toThrowError('Invalid size type')
 	})
 
 	test('Invalid owner', () => {
@@ -504,8 +506,10 @@ describe('Sanity checks', () => {
 			owner: 'emma',
 			status: NodeStatus.LOCKED,
 		})
-		// @ts-expect-error wrong type error check
-		expect(() => { file.status = 'invalid' }).toThrowError('Status must be a valid NodeStatus')
+		expect(() => {
+			// @ts-expect-error wrong type error check
+			file.status = 'invalid'
+		}).toThrowError('Status must be a valid NodeStatus')
 	})
 })
 
@@ -908,8 +912,10 @@ describe('Attributes update', () => {
 		})
 
 		// We can not update the owner
-		// @ts-expect-error owner is a read-only property
-		expect(() => { file.owner = 'admin' }).toThrowError()
+		expect(() => {
+			// @ts-expect-error owner is a read-only property
+			file.owner = 'admin'
+		}).toThrowError()
 		// The owner is still the original one
 		expect(file?.owner).toBe('emma')
 	})

__tests__/sidebar/sidebarTab.spec.ts

@@ -51,25 +51,28 @@ describe('Sidebar tabs', () => {
 
 	describe('Tab validation', () => {
 		it('fails with an invalid parameter', () => {
-			expect(
+			expect(() => {
 				// @ts-expect-error mocking for testing
-				() => registerSidebarTab(getExampleTab)).toThrowErrorMatchingInlineSnapshot('[Error: Sidebar tab is not an object]')
+				registerSidebarTab(getExampleTab)
+			}).toThrowErrorMatchingInlineSnapshot('[Error: Sidebar tab is not an object]')
 		})
 
 		it('fails with missing id', () => {
-			expect(
+			expect(() => {
 				// @ts-expect-error mocking for testing
-				() => registerSidebarTab({ ...getExampleTab(), id: undefined })).toThrowErrorMatchingInlineSnapshot('[Error: Sidebar tabs need to have an id conforming to the HTML id attribute specifications]')
+				registerSidebarTab({ ...getExampleTab(), id: undefined })
+			}).toThrowErrorMatchingInlineSnapshot('[Error: Sidebar tabs need to have an id conforming to the HTML id attribute specifications]')
 		})
 
 		it('fails with non conforming id', () => {
 			expect(() => registerSidebarTab({ ...getExampleTab(), id: 'this is invalid' })).toThrowErrorMatchingInlineSnapshot('[Error: Sidebar tabs need to have an id conforming to the HTML id attribute specifications]')
 		})
 
 		it('fails with missing tagName name', () => {
-			expect(
+			expect(() => {
 				// @ts-expect-error mocking for testing
-				() => registerSidebarTab({ ...getExampleTab(), tagName: undefined })).toThrowErrorMatchingInlineSnapshot('[Error: Sidebar tabs need to have the tagName name set]')
+				registerSidebarTab({ ...getExampleTab(), tagName: undefined })
+			}).toThrowErrorMatchingInlineSnapshot('[Error: Sidebar tabs need to have the tagName name set]')
 		})
 
 		it('fails with invalid tagName name', () => {
@@ -78,43 +81,49 @@ describe('Sidebar tabs', () => {
 		})
 
 		it('fails with missing name', () => {
-			expect(
+			expect(() => {
 				// @ts-expect-error mocking for testing
-				() => registerSidebarTab({ ...getExampleTab(), displayName: undefined })).toThrowErrorMatchingInlineSnapshot('[Error: Sidebar tabs need to have a name set]')
+				registerSidebarTab({ ...getExampleTab(), displayName: undefined })
+			}).toThrowErrorMatchingInlineSnapshot('[Error: Sidebar tabs need to have a name set]')
 		})
 
 		it('fails with invalid name', () => {
-			expect(
+			expect(() => {
 				// @ts-expect-error mocking for testing
-				() => registerSidebarTab({ ...getExampleTab(), displayName: 1234 })).toThrowErrorMatchingInlineSnapshot('[Error: Sidebar tabs need to have a name set]')
+				registerSidebarTab({ ...getExampleTab(), displayName: 1234 })
+			}).toThrowErrorMatchingInlineSnapshot('[Error: Sidebar tabs need to have a name set]')
 		})
 
 		it('fails with missing icon', () => {
-			expect(
+			expect(() => {
 				// @ts-expect-error mocking for testing
-				() => registerSidebarTab({ ...getExampleTab(), iconSvgInline: undefined })).toThrowErrorMatchingInlineSnapshot('[Error: Sidebar tabs need to have an valid SVG icon]')
+				registerSidebarTab({ ...getExampleTab(), iconSvgInline: undefined })
+			}).toThrowErrorMatchingInlineSnapshot('[Error: Sidebar tabs need to have an valid SVG icon]')
 		})
 
 		it('fails with invalid SVG icon', () => {
 			expect(() => registerSidebarTab({ ...getExampleTab(), iconSvgInline: 'icon-group' })).toThrowErrorMatchingInlineSnapshot('[Error: Sidebar tabs need to have an valid SVG icon]')
 		})
 
 		it('fails with missing order', () => {
-			expect(
+			expect(() => {
 				// @ts-expect-error mocking for testing
-				() => registerSidebarTab({ ...getExampleTab(), order: undefined })).toThrowErrorMatchingInlineSnapshot('[Error: Sidebar tabs need to have a numeric order set]')
+				registerSidebarTab({ ...getExampleTab(), order: undefined })
+			}).toThrowErrorMatchingInlineSnapshot('[Error: Sidebar tabs need to have a numeric order set]')
 		})
 
 		it('fails with invalid order', () => {
-			expect(
+			expect(() => {
 				// @ts-expect-error mocking for testing
-				() => registerSidebarTab({ ...getExampleTab(), order: '3' })).toThrowErrorMatchingInlineSnapshot('[Error: Sidebar tabs need to have a numeric order set]')
+				registerSidebarTab({ ...getExampleTab(), order: '3' })
+			}).toThrowErrorMatchingInlineSnapshot('[Error: Sidebar tabs need to have a numeric order set]')
 		})
 
 		it('fails with missing "enabled" method', () => {
-			expect(
+			expect(() => {
 				// @ts-expect-error mocking for testing
-				() => registerSidebarTab({ ...getExampleTab(), enabled: undefined })).toThrowErrorMatchingInlineSnapshot('[Error: Sidebar tabs need to have an "enabled" method]')
+				registerSidebarTab({ ...getExampleTab(), enabled: undefined })
+			}).toThrowErrorMatchingInlineSnapshot('[Error: Sidebar tabs need to have an "enabled" method]')
 		})
 	})
 })

lib/dav/index.ts

@@ -1,3 +1,4 @@
+/* eslint-disable jsdoc/check-tag-names */
 /*!
  * SPDX-FileCopyrightText: 2024 Nextcloud GmbH and Nextcloud contributors
  * SPDX-License-Identifier: AGPL-3.0-or-later