feat(upload): merge upload related API from @nextcloud/upload#1509
Merged
feat(upload): merge upload related API from @nextcloud/upload#1509
@nextcloud/upload#1509Conversation
susnux
added
type: enhancement
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1509 +/- ##
===========================================
- Coverage 86.05% 72.47% -13.59%
===========================================
Files 30 40 +10
Lines 667 1108 +441
Branches 195 274 +79
===========================================
+ Hits 574 803 +229
- Misses 80 272 +192
- Partials 13 33 +20 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
feat/merge-uploader
branch
from
2ba1041 to
2c4eb92
Compare
susnux
added
3. to review
ShGKme
reviewed
Mar 10, 2026
ShGKme
reviewed
Mar 10, 2026
Contributor
ShGKme
left a comment
ShGKme
left a comment
There was a problem hiding this comment.
Thanks for splitting into commits 💙
Only one comment
skjnldsv
reviewed
Mar 11, 2026
| * @param isPublic Set to true to use public upload endpoint (by default it is auto detected) | ||
| * @param forceRecreate Force a new uploader instance - main purpose is for testing | ||
| */ | ||
| export function getUploader(isPublic: boolean = isPublicShare(), forceRecreate = false): Uploader { |
Contributor
There was a problem hiding this comment.
I always wonder if we should not auto detect the public boolean. What if an app creates a normal instance and the other a public without forceCreate?
Contributor
Author
There was a problem hiding this comment.
yes we should!
but lets do changes in separate PRs this PR is mainly for copy it over and adjust code to work in this repo
skjnldsv
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As it was decided to move UI to the vue library it is easier to move the pure API to this library.
Reducing libraries to maintain and also it fits nicely into this libraries scope.
See individual commits - its mostly copy paste and slight adjustments to fit the shape of this library.