Skip to content

build(deps-dev): bump to ESLint v10 and properly declare optional globals#1074

Open
ShGKme wants to merge 3 commits intomainfrom
chore/eslint-v10
Open

build(deps-dev): bump to ESLint v10 and properly declare optional globals#1074
ShGKme wants to merge 3 commits intomainfrom
chore/eslint-v10

Conversation

@ShGKme
Copy link
Copy Markdown
Contributor

@ShGKme ShGKme commented May 5, 2026

dependabot Bot and others added 3 commits May 5, 2026 11:20
Bumps
[@nextcloud/eslint-config](https://github.com/nextcloud-libraries/eslint-config)
from 9.0.0-rc.8 to 9.0.0-rc.9.
- [Release
notes](https://github.com/nextcloud-libraries/eslint-config/releases)
-
[Changelog](https://github.com/nextcloud-libraries/eslint-config/blob/main/CHANGELOG.md)
-
[Commits](nextcloud-libraries/eslint-config@v9.0.0-rc.8...v9.0.0-rc.9)

---
updated-dependencies:
- dependency-name: "@nextcloud/eslint-config"
  dependency-version: 9.0.0-rc.9
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
- Do not treat these globals as guaranteed
- Do not re-declare globalThis as a variable

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme ShGKme requested review from Antreesy, GVodyanov and susnux May 5, 2026 09:45
@ShGKme ShGKme self-assigned this May 5, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.65%. Comparing base (1fbc0c6) to head (ec90660).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1074   +/-   ##
=======================================
  Coverage   83.65%   83.65%           
=======================================
  Files           6        6           
  Lines         208      208           
  Branches       86       86           
=======================================
  Hits          174      174           
  Misses         24       24           
  Partials       10       10           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants