Skip to content

build(deps-dev): bump to ESLint v10 and properly declare optional globals #1074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ShGKme wants to merge 3 commits into
base: main
Choose a base branch
from
+480 −376
Open

build(deps-dev): bump to ESLint v10 and properly declare optional globals #1074

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fee1168
build(deps-dev): Bump @nextcloud/eslint-config
dependabot[bot] Apr 23, 2026
d893d28
build(deps-dev): bump eslint from 9.39.2 to 10.3.0
ShGKme May 5, 2026
ec90660
refactor: declare SSR window globals as optional additional properties
ShGKme May 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions lib/date.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,10 @@
/// <reference types="@nextcloud/typings" />
/*!
* SPDX-FileCopyrightText: 2022 Nextcloud GmbH and Nextcloud contributors
* SPDX-License-Identifier: GPL-3.0-or-later
*/

import { getCanonicalLocale } from './locale.ts'

declare let globalThis: Nextcloud.v29.WindowWithGlobals

export type WeekDay = 0 | 1 | 2 | 3 | 4 | 5 | 6

/**
Expand Down
11 changes: 11 additions & 0 deletions lib/globals.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,15 +5,26 @@

/* eslint-disable camelcase */

/// <reference types="@nextcloud/typings" />

import type { PluralFunction, Translations } from './registry.ts'

declare global {
// Library shared global state
var _nc_l10n_locale: string | undefined
var _nc_l10n_language: string | undefined
var _nc_l10n_timezone: string | undefined

var _oc_l10n_registry_translations: Record<string, Translations> | undefined
var _oc_l10n_registry_plural_functions: Record<string, PluralFunction> | undefined

// Nextcloud server globals available on Nextcloud app in Web environment
var firstDay: Nextcloud.v29.WindowWithGlobals['firstDay'] | undefined
var dayNames: Nextcloud.v29.WindowWithGlobals['dayNames'] | undefined
var dayNamesShort: Nextcloud.v29.WindowWithGlobals['dayNamesShort'] | undefined
var dayNamesMin: Nextcloud.v29.WindowWithGlobals['dayNamesMin'] | undefined
var monthNames: Nextcloud.v29.WindowWithGlobals['monthNames'] | undefined
var monthNamesShort: Nextcloud.v29.WindowWithGlobals['monthNamesShort'] | undefined
}

export {}
Loading
Loading