feat(locale): add setTimezone & getTimezone functions

[Sector6759]

• Closes Feature request: implement a getTimeZone function #991

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.65%. Comparing base (d9d9de8) to head (d3c8cf2).
⚠️ Report is 24 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #992      +/-   ##
==========================================
+ Coverage   83.16%   83.65%   +0.48%     
==========================================
  Files           6        6              
  Lines         202      208       +6     
  Branches       84       86       +2     
==========================================
+ Hits          168      174       +6     
  Misses         24       24              
  Partials       10       10              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[Sector6759]

@ShGKme @susnux

Due to https://github.com/nextcloud-libraries/nextcloud-capabilities/blob/main/lib/index.ts#L11

console.debug('Could not find capabilities initial state fall back to _oc_capabilities')

the console output of the test runs now gets spammed with this message. We could switch to calling

loadState('core', 'capabilities')

directly, to circumvent this.

[ShGKme]

Looks good.

But we need to double-check that the timezone format from capabilities is the same as Intl supports

[ShGKme]

Due to https://github.com/nextcloud-libraries/nextcloud-capabilities/blob/main/lib/index.ts#L11

console.debug('Could not find capabilities initial state fall back to _oc_capabilities')

the console output of the test runs now gets spammed with this message. We could switch to calling

loadState('core', 'capabilities')

directly, to circumvent this.

I wouldn't change the used library in the main code due to spam log messages in the tests.

We should either silent the log in the tests or fix the library.

[Sector6759]

But we need to double-check that the timezone format from capabilities is the same as Intl supports

What do you mean by this? One of the following?

• Ensuring the timezone from the capabilities being a named IANA time zone
• Ensuring every time zone possibly set in the personal settings section being supported by the constructors and methods in the Intl namespace

[Sector6759]

We should either silent the log in the tests or fix the library.

We could pass --silent=passed-only as a CLI option to vitest, but I'm not the one to decide on that.

[susnux]

We could pass --silent=passed-only as a CLI option to vitest, but I'm not the one to decide on that.

Or just silence the specific output by having vi.spyOn(console, 'debug').mockImplementation(() => {])

[Sector6759]

Or just silence the specific output by having vi.spyOn(console, 'debug').mockImplementation(() => {])

I've added that line to the getTimezone tests.

[ShGKme]

Thanks!

Could you squash into a single commit, since all the changes where only "fixups" from the review in a small feature?

[Sector6759]

Could you squash into a single commit, since all the changes where only "fixups" from the review in a small feature?

Isn't that something one of you guys have to do when merging?

From the docs:

To squash and merge pull requests, you must have write permissions in the repository, and the repository must allow squash merging.

[ShGKme]

Isn't that something one of you guys have to do when merging?

We don't have merge squash. But you can do anything in your own branch, including squashing into a single commit, and force-push

[Sector6759]

Alright, I've squashed the commits.