Skip to content

fix: make lib side effects free#996

Merged
susnux merged 1 commit intomainfrom
fix/side-effects-free
Dec 22, 2025
Merged

fix: make lib side effects free#996
susnux merged 1 commit intomainfrom
fix/side-effects-free

Conversation

@ShGKme
Copy link
Copy Markdown
Contributor

@ShGKme ShGKme commented Dec 22, 2025

Initialize on the first usage instead of the module scope

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme ShGKme requested a review from susnux December 22, 2025 15:54
@ShGKme ShGKme self-assigned this Dec 22, 2025
@ShGKme ShGKme added type: bug 🐛 Something isn't working 3. to review 3️⃣ Waiting for reviews labels Dec 22, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 22, 2025

Codecov Report

❌ Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 83.65%. Comparing base (3d02991) to head (acc465a).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
lib/locale.ts 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #996   +/-   ##
=======================================
  Coverage   83.65%   83.65%           
=======================================
  Files           6        6           
  Lines         208      208           
  Branches       86       86           
=======================================
  Hits          174      174           
  Misses         24       24           
  Partials       10       10           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@susnux susnux merged commit b441e5d into main Dec 22, 2025
12 checks passed
@susnux susnux deleted the fix/side-effects-free branch December 22, 2025 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review 3️⃣ Waiting for reviews type: bug 🐛 Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants