Skip to content

feat: use status header on recent Nextcloud versions to detect confirmation error#1359

Merged
susnux merged 2 commits intomainfrom
feat/use-header
Mar 18, 2026
Merged

feat: use status header on recent Nextcloud versions to detect confirmation error#1359
susnux merged 2 commits intomainfrom
feat/use-header

Conversation

@susnux
Copy link
Copy Markdown
Collaborator

@susnux susnux commented Mar 17, 2026

This is required so that if an API call fails because of e.g. user input error and not because of wrong password the app can handle the error.

E.g. try to create invalid external storage - there is no way to fix it or handle it in the app because the confirmation dialog will never be closed.

@susnux susnux added enhancement New feature or request 3. to review Waiting for reviews labels Mar 17, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 17, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (b42d001) to head (83be4c5).
⚠️ Report is 21 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1359   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         5    +1     
  Lines           20        30   +10     
  Branches         3         6    +3     
=========================================
+ Hits            20        30   +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@susnux susnux force-pushed the feat/use-header branch 2 times, most recently from 6b5e751 to ad8af40 Compare March 17, 2026 22:21
susnux added 2 commits March 17, 2026 23:23
…mation error

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux merged commit a7e8c91 into main Mar 18, 2026
12 checks passed
@susnux susnux deleted the feat/use-header branch March 18, 2026 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants