Merge pull request #6961 from nextcloud-libraries/chore/remove-deprecated-prop

chore: remove deprecated `aria-hidden` prop from `NcAction*`

Author: susnux

CHANGELOG.md

@@ -125,6 +125,8 @@ Especially the following are now provided as composables:
 The `richEditing` mixin can be replaced by just using the `NcRichText` component.
 
 #### Other breaking changes
+- `NcActions` and `NcAction*`
+  - The `ariaHidden` property is removed, please do no longer provide it, otherwise the root element will inherit incorrect aria-hidden.
 - `NcAppSidebar`
   - The `closing` and `opening` events were removed.
     They are directly emitted when the sidebar was opened when using `v-if`

src/components/NcActionButton/NcActionButton.vue

@@ -396,16 +396,6 @@ export default {
 	},
 
 	props: {
-		/**
-		 * @deprecated To be removed in @nextcloud/vue 9. Migration guide: remove ariaHidden prop from NcAction* components.
-		 * @todo Add a check in @nextcloud/vue 9 that this prop is not provided,
-		 * otherwise root element will inherit incorrect aria-hidden.
-		 */
-		ariaHidden: {
-			type: Boolean,
-			default: null,
-		},
-
 		/**
 		 * disabled state of the action button
 		 */

src/components/NcActionInput/NcActionInput.vue

@@ -353,15 +353,6 @@ export default {
 			type: String,
 			default: '',
 		},
-		/**
-		 * @deprecated To be removed in @nextcloud/vue 9. Migration guide: remove ariaHidden prop from NcAction* components.
-		 * @todo Add a check in @nextcloud/vue 9 that this prop is not provided,
-		 * otherwise root element will inherit incorrect aria-hidden.
-		 */
-		ariaHidden: {
-			type: Boolean,
-			default: null,
-		},
 		/**
 		 * Attribute forwarded to the underlying NcPasswordField and NcTextField
 		 */

src/components/NcActionLink/NcActionLink.vue

@@ -164,15 +164,6 @@ export default {
 			type: String,
 			default: null,
 		},
-		/**
-		 * @deprecated To be removed in @nextcloud/vue 9. Migration guide: remove ariaHidden prop from NcAction* components.
-		 * @todo Add a check in @nextcloud/vue 9 that this prop is not provided,
-		 * otherwise root element will inherit incorrect aria-hidden.
-		 */
-		ariaHidden: {
-			type: Boolean,
-			default: null,
-		},
 	},
 }
 </script>

src/components/NcActions/NcActions.vue

@@ -1038,16 +1038,6 @@ export default {
 			default: t('Actions'),
 		},
 
-		/**
-		 * @deprecated To be removed in @nextcloud/vue 9. Migration guide: remove ariaHidden prop from NcAction* components.
-		 * @todo Add a check in @nextcloud/vue 9 that this prop is not provided,
-		 * otherwise root element will inherit incorrect aria-hidden.
-		 */
-		ariaHidden: {
-			type: Boolean,
-			default: null,
-		},
-
 		/**
 		 * Wanted direction of the menu
 		 */
@@ -1260,6 +1250,10 @@ export default {
 		useTrapStackControl(() => this.opened, {
 			disabled: () => this.config.withFocusTrap,
 		})
+
+		if ('ariaHidden' in this.$attrs) {
+			warn('[NcActions]: Do not set the ariaHidden attribute as the root element will inherit the incorrect aria-hidden.')
+		}
 	},
 
 	methods: {

src/mixins/actionText.js

@@ -5,6 +5,7 @@
 
 import actionGlobal from './actionGlobal.js'
 import { NC_ACTIONS_CLOSE_MENU } from '../components/NcActions/useNcActions.ts'
+import { warn } from 'vue'
 
 export default {
 	mixins: [actionGlobal],
@@ -44,15 +45,6 @@ export default {
 			type: String,
 			default: null,
 		},
-		/**
-		 * @deprecated To be removed in @nextcloud/vue 9. Migration guide: remove ariaHidden prop from NcAction* components.
-		 * @todo Add a check in @nextcloud/vue 9 that this prop is not provided,
-		 * otherwise root element will inherit incorrect aria-hidden.
-		 */
-		ariaHidden: {
-			type: Boolean,
-			default: null,
-		},
 	},
 
 	inject: {
@@ -65,6 +57,12 @@ export default {
 		'click',
 	],
 
+	created() {
+		if ('ariaHidden' in this.$attrs) {
+			warn('[NcAction*]: Do not set the ariaHidden attribute as the root element will inherit the incorrect aria-hidden.')
+		}
+	},
+
 	computed: {
 		/**
 		 * Check if icon prop is an URL