feat(NcPopover): auto return focus to trigger button on close#5155
Merged
feat(NcPopover): auto return focus to trigger button on close#5155
Conversation
be836c0 to
1f34a6c
Compare
susnux
approved these changes
Apr 7, 2025
Contributor
susnux
left a comment
There was a problem hiding this comment.
Rebased onto stable8.
Tested it and the EmojiPicker bug is resolved with this 🚀
Contributor
|
/backport to main |
Contributor
Author
I don't remember why I did it, and I'm almost sure it was fixed another way around 🙈 |
Contributor
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Antreesy
approved these changes
Aug 29, 2025
2 tasks
Contributor
Author
|
🤨 |
3 tasks
Contributor
Author
Contributor
Author
|
Or @AndyScherzinger as you pushed something |
Contributor
|
I didn't check the dates, thought it's just rebased |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
🖼️ Screenshots
🚧 Tasks
NcPopovertrigger and use it as fallback forsetReturnFocusnoAutoReturnFocusto optionally disable this behaviorNcActionsNcActions🏁 Checklist