[stable8] fix(NcAppContent): don't remove list when showing details in mobile or no-split mode#6261
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stable8 #6261 +/- ##
==========================================
Coverage ? 43.11%
==========================================
Files ? 161
Lines ? 4112
Branches ? 1070
==========================================
Hits ? 1773
Misses ? 2220
Partials ? 119 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ShGKme
reviewed
Nov 23, 2024
d82dbf3 to
c2832fa
Compare
Contributor
Author
c2832fa to
0bffe7b
Compare
Contributor
|
hi, sorry for the late reply, i wrote on our frontend talk room, so more people are involved to get a decision. |
susnux
reviewed
Apr 1, 2025
0bffe7b to
3da5624
Compare
susnux
approved these changes
Apr 1, 2025
susnux
left a comment
Contributor
There was a problem hiding this comment.
Makes sense from my view. but should be checked with mail
3 tasks
…r no-split mode Signed-off-by: Wolfgang <github@linux-dude.de>
3da5624 to
c27d399
Compare
GretaD
approved these changes
Apr 17, 2025
Contributor
|
/backport to main |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
As mentioned in #6204 the change in 8.10.0 causes the item list to rebuild every time the details of an item are shown.
With a dynamic list like in the news app, where read items are removed from the list when refreshing it, this means that the selected item you looked at the details are gone immediately when you close the details.
It also affects the performance, because of the rebuilding when closing the details, which is notable on mobile devices.
I think there is no technical reason to delete it, so it is better to just hide the list.