Skip to content

feat(NcDateTimePicker): add time range picker and align naming#6728

Merged
susnux merged 1 commit intomainfrom
feat/time-picker
Apr 7, 2025
Merged

feat(NcDateTimePicker): add time range picker and align naming#6728
susnux merged 1 commit intomainfrom
feat/time-picker

Conversation

@susnux
Copy link
Copy Markdown
Contributor

@susnux susnux commented Apr 5, 2025

☑️ Resolves

  1. Add a time range picker mode
  2. Align type names to TYPE(-range)?
  3. Fix some issues related to time mode (also without range)

🖼️ Screenshots

Screenshot 2025-04-05 at 18-05-34 Nextcloud Vue Style Guide

Screenshot 2025-04-05 at 18-05-43 Nextcloud Vue Style Guide

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 2️⃣ Backport bugfixes to stable8 for maintained Vue 2 version.

@susnux susnux added enhancement New feature or request 3. to review Waiting for reviews feature: datepicker Related to the date/time picker component labels Apr 5, 2025
@susnux susnux added this to the v9.0.0-rc.0 milestone Apr 5, 2025
@susnux susnux requested review from Antreesy, ShGKme and st3iny April 5, 2025 16:09
@susnux susnux force-pushed the feat/time-picker branch from 5b4faa6 to e204bfa Compare April 5, 2025 16:12
@susnux susnux closed this Apr 5, 2025
@susnux susnux reopened this Apr 5, 2025
@susnux
Copy link
Copy Markdown
Contributor Author

susnux commented Apr 5, 2025

UI reloaded while clicking into the comment box -> closed by accident 😔
Needed to push a fix as I forgot to adjust the documentation of the type prop.

@susnux susnux force-pushed the feat/time-picker branch from e204bfa to f7c276a Compare April 6, 2025 13:42
@susnux
Copy link
Copy Markdown
Contributor Author

susnux commented Apr 6, 2025

Only rebased to resolve conflicts - no changes.

Comment thread src/components/NcDateTimePicker/NcDateTimePicker.vue
@st3iny
Copy link
Copy Markdown
Contributor

st3iny commented Apr 7, 2025

Can't wait to use this in Calendar 🤩

1. Add a time range picker mode
2. Align type names to `TYPE(-range)?`
3. Fix some issues related to time mode (also without range)

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux force-pushed the feat/time-picker branch from f7c276a to bfcb8de Compare April 7, 2025 18:47
@susnux susnux merged commit 5023ed3 into main Apr 7, 2025
24 checks passed
@susnux susnux deleted the feat/time-picker branch April 7, 2025 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews enhancement New feature or request feature: datepicker Related to the date/time picker component

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants