fix(dialogs/spawnDialog): improve typing#6770
Closed
ShGKme wants to merge 2 commits into
Closed
Conversation
ShGKme
commented
Apr 11, 2025
Comment on lines
+50
to
+55
| export function spawnDialog< | ||
| C extends Component, | ||
| Props extends Record<EventPropName<'close'>, (...payload: unknown[]) => unknown> = ComponentProps<C>, // eslint-disable-line space-before-function-paren | ||
| Payload extends unknown[] = EventPayload<NonNullable<Props[EventPropName<'close'>]>>, | ||
| >( | ||
| dialog: C, |
Contributor
Author
There was a problem hiding this comment.
I don't understand why it works, we C is specified as typeof MyDialog, but it cannot infer it from MyDialog passed to the dialog param...
Contributor
Author
|
For manual testing: const ComponentNoEvent = defineComponent({
name: 'Component1',
props: {
foo: {
type: Number,
required: true,
},
},
})
const Component1 = defineComponent({
name: 'Component1',
props: {
foo: Number,
},
emits: {
close: () => true,
},
})
const Component2 = defineComponent({
name: 'Component2',
props: {
foo: Number,
},
emits: {
close: (payload: Date) => true,
open: () => true,
},
})
const Component3 = defineComponent({
name: 'Component3',
props: {
foo: Number,
},
emits: {
close: (a: number, b: number) => true,
},
})
const result0 = await spawnDialog(ComponentNoEvent, { foo: 1 }) // Should be never
const result1 = await spawnDialog(Component1, { foo: 1 }) // Should be void
const result2 = await spawnDialog(Component2, { foo: 1 })
console.log(result2[0].toISOString())
const result3 = await spawnDialog(Component3, { foo: 1 })
console.log(-result3[0] - result3[1]) |
4 tasks
Contributor
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
🖼️ Screenshots
🚧 Tasks
🏁 Checklist
stable8for maintained Vue 2 version or not applicable