fix(NcRichText): references prop type#6799
Merged
Merged
Conversation
…bject Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
julien-nc
added
bug
Contributor
Author
|
/backport to stable8 |
ShGKme
approved these changes
Apr 17, 2025
ShGKme
changed the title
references prop type
susnux
approved these changes
Apr 17, 2025
susnux
reviewed
Apr 17, 2025
| referenceData: { | ||
| type: Object, | ||
| type: Array, | ||
| default: null, |
Contributor
There was a problem hiding this comment.
How can it be null but type Array? (null is object)
Should the default not be rather () => [] (empty array?) or undefined?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The references prop is passed to
NcReferenceListand is processed as a list, not an object. This prevents Vue warnings and fixes the docs.🏁 Checklist
stable8for maintained Vue 2 version or not applicable