feat(NcActionButton): introduce description prop#6932
Conversation
subline prop
|
Looks good! I'm wondering if we should align the icon with the title instead of centering it in the whole action item element. I remember @marcoambrosini had some thoughts about this? |
|
Yes, to tidy up things visually, the icon should be aligned with the title of the actionbutton |
It's unrelated, applied to all action items |
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
41c55b2 to
4d393e4
Compare
nimishavijay
left a comment
There was a problem hiding this comment.
If the icon alignment is a separate issue, approving this PR for default + subline 👍
If this is semantically a description, maybe also name the prop |
I would second that (seems to be also a bit more consistent with our prop names in general). |
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
4d393e4 to
5a6b062
Compare
subline propdescription prop
|
/backport to stable8 |
☑️ Resolves
nameprop +defaultslot is a bit bulkydefaultslot +sublineprop🖼️ Screenshots
Documentation screenshot:

Same content comparison:

🚧 Tasks
🏁 Checklist
stable8for maintained Vue 2 version or not applicable