Skip to content

Hiding the description for width < 450 negatively impacts rendering in Talk #8524

Description

@tyzbit

As implemented in Talk and discussed in this issue nextcloud/spreed#17881, when the width for the embed widget is <450, the description is not shown due to the size of the widget. I am not familiar with this code so I can't estimate the impact of changing this for all downstream consumers this but for the use case in Talk, the description should not be hidden.

Relevant code:

const numberOfLines = computed(() => {
// no description for width < 450, one line until 550 and so on
const lineCountOffsets = [450, 550, 650, Infinity]
return lineCountOffsets.findIndex((max) => width.value < max)
})
const descriptionStyle = computed(() => {
if (numberOfLines.value === 0) {
return {
display: 'none',
}
}
const lineClamp = numberOfLines.value
return {
lineClamp,
webkitLineClamp: lineClamp,
}
})

Thank you and apologies in advance if this issue is not appropriate or if there are any errors as I'm not familiar with this codebase.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions