Skip to content

[stable8] feat(NcReferenceWidget): allow to enable resizable widget height#8665

Merged
susnux merged 3 commits into
stable8from
feat/stable8/resize_custom_widget_height
Jun 30, 2026
Merged

[stable8] feat(NcReferenceWidget): allow to enable resizable widget height#8665
susnux merged 3 commits into
stable8from
feat/stable8/resize_custom_widget_height

Conversation

@mejo-

@mejo- mejo- commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

β˜‘οΈ Resolves

Allows widgets to flag themselves as resizable, which adds a resize drag handle to resize them horizontally. Particularly useful for embedded office documents, tables and deck boards in a Text file.

Required to fix nextcloud/text#8279

Developed against stable8 on purpose as Text and Deck apps are still on Vue 2, but already forward-ported locally to main branch.

Intending to set isResizable: true at least in files and deck board widget for a starter.

πŸ–ΌοΈ Screencasts

🏑 After
recording

🏁 Checklist

  • [] ⛑️ Tests are included or are not applicable
  • πŸ“˜ Component documentation has been extended, updated or is not applicable
  • 2️⃣ Backport to stable8 for maintained Vue 2 version or not applicable

@mejo- mejo- self-assigned this Jun 23, 2026
@mejo- mejo- added the 3. to review Waiting for reviews label Jun 23, 2026
@ShGKme ShGKme changed the title feat(NcReferenceWidget): allow to enable resizable widget height [stable8] feat(NcReferenceWidget): allow to enable resizable widget height Jun 23, 2026
@ShGKme ShGKme added the enhancement New feature or request label Jun 23, 2026
@codecov

codecov Bot commented Jun 23, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.
βœ… Project coverage is 46.70%. Comparing base (488cb5a) to head (8160e7f).

Files with missing lines Patch % Lines
src/components/NcRichText/NcReferenceWidget.vue 0.00% 6 Missing ⚠️
src/functions/reference/widgets.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           stable8    #8665      +/-   ##
===========================================
- Coverage    46.85%   46.70%   -0.16%     
===========================================
  Files          195      195              
  Lines         4926     4944      +18     
  Branches      1268     1273       +5     
===========================================
+ Hits          2308     2309       +1     
- Misses        2529     2546      +17     
  Partials        89       89              

β˜” View full report in Codecov by Harness.
πŸ“’ Have feedback on the report? Share it here.

πŸš€ New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • πŸ“¦ JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread src/components/NcRichText/NcReferenceWidget.vue Outdated
Comment thread src/components/NcRichText/NcReferenceWidget.vue Outdated
@mejo- mejo- force-pushed the feat/stable8/resize_custom_widget_height branch from f102d4e to d666648 Compare June 25, 2026 12:13
@mejo- mejo- requested a review from ShGKme June 25, 2026 12:16
@mejo- mejo- force-pushed the feat/stable8/resize_custom_widget_height branch from d666648 to 8199a3b Compare June 25, 2026 12:43
Comment thread src/components/NcRichText/NcReferenceWidget.vue
Comment thread src/components/NcRichText/NcReferenceWidget.vue Outdated
Comment thread src/components/NcRichText/NcReferenceWidget.vue Outdated
Comment thread src/components/NcRichText/NcReferenceWidget.vue Outdated
@mejo- mejo- force-pushed the feat/stable8/resize_custom_widget_height branch from 8199a3b to 4e1d80a Compare June 29, 2026 20:20
@mejo- mejo- requested a review from ShGKme June 29, 2026 20:20
Signed-off-by: Jonas <jonas@freesources.org>
@mejo- mejo- force-pushed the feat/stable8/resize_custom_widget_height branch from 4e1d80a to 56f3cd0 Compare June 29, 2026 20:54
Comment thread src/components/NcRichText/NcReferenceWidget.vue Outdated
mejo- added 2 commits June 29, 2026 23:26
Signed-off-by: Jonas <jonas@freesources.org>
Signed-off-by: Jonas <jonas@freesources.org>
@mejo- mejo- force-pushed the feat/stable8/resize_custom_widget_height branch from 56f3cd0 to 8160e7f Compare June 29, 2026 21:26
@mejo- mejo- requested a review from ShGKme June 29, 2026 21:26

@ShGKme ShGKme left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Windows Vivaldi and Android Firefox, works and looks well with mouse, finger, keyboard and screen reader.

@susnux

susnux commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

/backport to main

@susnux susnux merged commit bb74a96 into stable8 Jun 30, 2026
17 of 19 checks passed
@susnux susnux deleted the feat/stable8/resize_custom_widget_height branch June 30, 2026 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants