Skip to content

feat(NcActions): add wide prop for full-width menus#8698

Merged
susnux merged 1 commit into
nextcloud-libraries:mainfrom
Chartman123:feat/NcActions-wide-prop
Jul 1, 2026
Merged

feat(NcActions): add wide prop for full-width menus#8698
susnux merged 1 commit into
nextcloud-libraries:mainfrom
Chartman123:feat/NcActions-wide-prop

Conversation

@Chartman123

@Chartman123 Chartman123 commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

☑️ Resolves

🖼️ Screenshots

🏚️ Before 🏡 After
image image

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 2️⃣ Backport to stable8 for maintained Vue 2 version or not applicable

@codecov

codecov Bot commented Jun 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 53.10%. Comparing base (fef17a7) to head (b395012).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8698   +/-   ##
=======================================
  Coverage   53.10%   53.10%           
=======================================
  Files         106      106           
  Lines        3544     3544           
  Branches     1023     1022    -1     
=======================================
  Hits         1882     1882           
  Misses       1406     1406           
  Partials      256      256           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Chartman123 Chartman123 marked this pull request as ready for review June 30, 2026 22:42
@Chartman123

Copy link
Copy Markdown
Contributor Author

I wasn't able to add screenshots yesterday, Github didn't let me. I'll try again this evening

@susnux

susnux commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Can you add a case to the docs? Otherwise this looks fine and in sync with NcButton

Signed-off-by: Christian Hartmann <chris-hartmann@gmx.de>
@Chartman123 Chartman123 force-pushed the feat/NcActions-wide-prop branch from 08298aa to b395012 Compare July 1, 2026 11:34
@susnux susnux added enhancement New feature or request 3. to review Waiting for reviews feature: actions Related to the actions components labels Jul 1, 2026
@susnux susnux added this to the 9.9.0 milestone Jul 1, 2026
@susnux susnux requested review from Antreesy, ShGKme and susnux July 1, 2026 11:57

@susnux susnux left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense from my point of view

@ShGKme

ShGKme commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

/backport to stable8

@susnux susnux merged commit 631c8b1 into nextcloud-libraries:main Jul 1, 2026
24 checks passed
@Chartman123 Chartman123 deleted the feat/NcActions-wide-prop branch July 1, 2026 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews enhancement New feature or request feature: actions Related to the actions components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[NcActions] enh: add wide setting like for NcButton

3 participants