Skip to content

fix(NcPopover): regression with incorrect size on RTL #6796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Antreesy merged 1 commit into from
Apr 17, 2025
Merged

fix(NcPopover): regression with incorrect size on RTL #6796

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 22 additions & 9 deletions src/components/NcPopover/NcPopover.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -416,7 +416,8 @@ $arrow-position: $arrow-width - 1px;
.resize-observer {
position: absolute;
top: 0;
inset-inline-start: 0;
/* stylelint-disable-next-line csstools/use-logical */ /* upstream logic */
left: 0;
z-index: -1;
width: 100%;
height: 100%;
Expand All @@ -431,7 +432,8 @@ $arrow-position: $arrow-width - 1px;
display: block;
position: absolute;
top: 0;
inset-inline-start: 0;
/* stylelint-disable-next-line csstools/use-logical */ /* upstream logic */
left: 0;
height: 100%;
width: 100%;
overflow: hidden;
Expand All @@ -449,7 +451,8 @@ $arrow-position: $arrow-width - 1px;
&.v-popper__popper {
z-index: 100000;
top: 0;
inset-inline-start: 0;
/* stylelint-disable-next-line csstools/use-logical */ /* upstream logic */
left: 0;
display: block !important;

.v-popper__wrapper {
Expand Down Expand Up @@ -485,26 +488,36 @@ $arrow-position: $arrow-width - 1px;

&[data-popper-placement^='top'] .v-popper__arrow-container {
bottom: -$arrow-position;
/* stylelint-disable-next-line csstools/use-logical */ /* upstream logic */
border-bottom-width: 0;
/* stylelint-disable-next-line csstools/use-logical */ /* upstream logic */
border-top-color: var(--color-main-background);
}

&[data-popper-placement^='bottom'] .v-popper__arrow-container {
top: -$arrow-position;
/* stylelint-disable-next-line csstools/use-logical */ /* upstream logic */
border-top-width: 0;
/* stylelint-disable-next-line csstools/use-logical */ /* upstream logic */
border-bottom-color: var(--color-main-background);
}

&[data-popper-placement^='right'] .v-popper__arrow-container {
inset-inline-start: -$arrow-position;
border-inline-start-width: 0;
border-inline-end-color: var(--color-main-background);
/* stylelint-disable-next-line csstools/use-logical */ /* upstream logic */
left: -$arrow-position;
/* stylelint-disable-next-line csstools/use-logical */ /* upstream logic */
border-left-width: 0;
/* stylelint-disable-next-line csstools/use-logical */ /* upstream logic */
border-right-color: var(--color-main-background);
}

&[data-popper-placement^='left'] .v-popper__arrow-container {
inset-inline-end: -$arrow-position;
border-inline-end-width: 0;
border-inline-start-color: var(--color-main-background);
/* stylelint-disable-next-line csstools/use-logical */ /* upstream logic */
right: -$arrow-position;
/* stylelint-disable-next-line csstools/use-logical */ /* upstream logic */
border-right-width: 0;
/* stylelint-disable-next-line csstools/use-logical */ /* upstream logic */
border-left-color: var(--color-main-background);
}

&[aria-hidden='true'] {
Expand Down
2 changes: 1 addition & 1 deletion src/components/NcRichContenteditable/NcRichContenteditable.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1085,7 +1085,7 @@ export default {
overflow: auto;
// Hide container root element while initializing
position: absolute;
/* stylelint-disable csstools/use-logical */ /* upstream logic */
/* stylelint-disable-next-line csstools/use-logical */ /* upstream logic */
left: -100vw;
// Space it out a bit from the text
margin: var(--default-grid-baseline) 0;
Expand Down
Loading