chore(dev-deps): bump @nextcloud/stylelint-config from 3.0.1 to 3.1.0 and fix errors#6955
Conversation
ShGKme
force-pushed
the
chore/stylelint-upgrade
branch
from
c3ad377 to
88637eb
Compare
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
…p: break-word` Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
susnux
force-pushed
the
chore/stylelint-upgrade
branch
from
88637eb to
3f7e933
Compare
susnux
left a comment
susnux
left a comment
There was a problem hiding this comment.
expect the scripts its good
| ], | ||
| }, | ||
| ], | ||
| 'scss/load-partial-extension': ['always'], |
There was a problem hiding this comment.
New rule not really "fix errors" ;)
There was a problem hiding this comment.
I don't understand the problem. I did not say it "fixes errors". Although it technically does - it decreases ammount error from 7 to 1.
As said in the note in the PR description, it is the opposite of what we had in the past. But in the past the rule (that was deprecated and replaced) worked differently - so we had mixed style.
I corrected the rule to the style we use in the repository de facto. If this is fine - we can addjust the rule in upstream as well.
If we actually want the opposite, we can remove the rule, and fix it the other way around.
There are 2 options - that why there was a question in the PR desription ;)
There was a problem hiding this comment.
I don't understand the problem
Its not a problem but unexpected with the PR description.
I expected only fixing errors in code and adjusting the config for the updated deps, not new rules to be enforced ;)
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
3 participants
☑️ Resolves
scss/load-partial-extensionwas onneverbut somehow didn't work in the previous config.But we always put the extension. Should we change it in the config or migrate to recommended?