Skip to content

build(deps): make vue@3 and vue-router@5 peer dependencies#8156

Draft
ShGKme wants to merge 2 commits into
mainfrom
chore/vue-and-vue-router-as-peer-deps
Draft

build(deps): make vue@3 and vue-router@5 peer dependencies#8156
ShGKme wants to merge 2 commits into
mainfrom
chore/vue-and-vue-router-as-peer-deps

Conversation

@ShGKme

@ShGKme ShGKme commented Feb 3, 2026

Copy link
Copy Markdown
Contributor

☑️ Resolves

  • Alternative for build(deps): allow vue-router ^4.6.4 or ^5.0.2 #8155
  • Makes Vue and Vue-Router required to be on the last major version in apps using the library
  • I'd merge it only after the final Nextcloud 33 release just in case there is a problem with vue-router@5

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 2️⃣ Backport to stable8 for maintained Vue 2 version or not applicable

@ShGKme ShGKme self-assigned this Feb 3, 2026
@ShGKme ShGKme added the dependencies Pull requests that update a dependency file label Feb 3, 2026
@codecov

codecov Bot commented Feb 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 54.06%. Comparing base (508cedf) to head (7827589).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8156   +/-   ##
=======================================
  Coverage   54.06%   54.06%           
=======================================
  Files         106      106           
  Lines        3479     3479           
  Branches     1009     1009           
=======================================
  Hits         1881     1881           
  Misses       1354     1354           
  Partials      244      244           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@susnux susnux left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense!

@susnux susnux added the 3. to review Waiting for reviews label Jun 27, 2026
@susnux susnux marked this pull request as ready for review June 27, 2026 17:59
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@susnux susnux force-pushed the chore/vue-and-vue-router-as-peer-deps branch from 4512199 to b6176bc Compare June 27, 2026 18:01
@susnux

susnux commented Jun 27, 2026

Copy link
Copy Markdown
Contributor

(rebased because of conflicts in package lock - resolved)

@susnux susnux marked this pull request as draft June 27, 2026 18:01
@susnux

susnux commented Jun 27, 2026

Copy link
Copy Markdown
Contributor

I'd merge it only after the final Nextcloud 33 release just in case there is a problem with vue-router@5

Thats now :)
Do you think its ready to review @ShGKme ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants