fix(NcRichText): render invalid relative markdown links as external#8397
Open
fix(NcRichText): render invalid relative markdown links as external#8397
Conversation
- with autolink + useMarkdown props [href2](href1) syntax is rendered as <a href1><a href2>href2</a></a> instead of href2 being a plain text Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
- add noExtDecoration prop for reusing the component Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
- this covers external links, internal absolute links, and internal relative links, that do not have a router match for current app - possibly a breaking change Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8397 +/- ##
==========================================
- Coverage 54.09% 54.08% -0.01%
==========================================
Files 104 105 +1
Lines 3398 3400 +2
Branches 989 990 +1
==========================================
+ Hits 1838 1839 +1
- Misses 1321 1322 +1
Partials 239 239 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
fix(autolink): fix rendering of nested markdown link with
[href2](href1)syntax is rendered as<a href1><a href2>href2</a></a>instead of href2 being a plain textfix(NcRichText)!: render all non-resolved links as external
🚧 Tasks
🏁 Checklist
stable8for maintained Vue 2 version or not applicable