Skip to content

fix(NcRichText): do not render nested links in markdown#8449

Open
Antreesy wants to merge 4 commits intomainfrom
fix/8397/nested-links
Open

fix(NcRichText): do not render nested links in markdown#8449
Antreesy wants to merge 4 commits intomainfrom
fix/8397/nested-links

Conversation

@Antreesy
Copy link
Copy Markdown
Contributor

☑️ Resolves

🖼️ Screenshots

🏚️ Before 🏡 After
image imageimage

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 2️⃣ Backport to stable8 for maintained Vue 2 version or not applicable

Antreesy added 4 commits April 7, 2026 13:39
 - with autolink + useMarkdown props [href2](href1) syntax is rendered as <a href1><a href2>href2</a></a> instead of href2 being a plain text

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
…' dependency

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
- essentially it's the same visitor underneath, just allow access all parents stack (ancestor)

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy added this to the 9.7.0 milestone Apr 21, 2026
@Antreesy Antreesy requested review from ShGKme and susnux April 21, 2026 11:35
@Antreesy Antreesy self-assigned this Apr 21, 2026
@Antreesy Antreesy added bug Something isn't working 3. to review Waiting for reviews feature: richtext Related to the richtext component labels Apr 21, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 21, 2026

Codecov Report

❌ Patch coverage is 95.23810% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 54.69%. Comparing base (7b8d777) to head (7fda70f).
⚠️ Report is 107 commits behind head on main.

Files with missing lines Patch % Lines
src/components/NcRichText/autolink.ts 91.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8449      +/-   ##
==========================================
+ Coverage   54.09%   54.69%   +0.60%     
==========================================
  Files         104      104              
  Lines        3398     3406       +8     
  Branches      989      994       +5     
==========================================
+ Hits         1838     1863      +25     
+ Misses       1321     1304      -17     
  Partials      239      239              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Antreesy Antreesy requested a review from DorraJaouad April 23, 2026 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug Something isn't working feature: richtext Related to the richtext component

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants