[stable8] fix(NcRichText): do not render nested links in markdown#8465
Merged
[stable8] fix(NcRichText): do not render nested links in markdown#8465
Conversation
- with autolink + useMarkdown props [href2](href1) syntax is rendered as <a href1><a href2>href2</a></a> instead of href2 being a plain text Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
cd4524b to
218eaf4
Compare
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
…' dependency Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
- essentially it's the same visitor underneath, just allow access all parents stack (ancestor) Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
218eaf4 to
806dad4
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## stable8 #8465 +/- ##
===========================================
+ Coverage 46.53% 46.64% +0.10%
===========================================
Files 194 194
Lines 4891 4901 +10
Branches 1263 1265 +2
===========================================
+ Hits 2276 2286 +10
Misses 2527 2527
Partials 88 88 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Antreesy
approved these changes
Apr 23, 2026
Contributor
Antreesy
left a comment
There was a problem hiding this comment.
Tested on deployed preview (nested md links, placeholders, code blocks)
3 tasks
ShGKme
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #8449
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.