Skip to content

[stable8] fix(NcRichText): do not render nested links in markdown#8465

Merged
Antreesy merged 4 commits intostable8from
backport/8449/stable8
Apr 23, 2026
Merged

[stable8] fix(NcRichText): do not render nested links in markdown#8465
Antreesy merged 4 commits intostable8from
backport/8449/stable8

Conversation

@backportbot
Copy link
Copy Markdown

@backportbot backportbot Bot commented Apr 23, 2026

Backport of #8449

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
    • adjusted tests for Vue2
    • refactored last commit for .js
  • Review and verify the backported changes
  • Remove all the empty commits

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot backportbot Bot added bug Something isn't working 3. to review Waiting for reviews feature: richtext Related to the richtext component labels Apr 23, 2026
@backportbot backportbot Bot added this to the 8.38.0 milestone Apr 23, 2026
 - with autolink + useMarkdown props [href2](href1) syntax is rendered as <a href1><a href2>href2</a></a> instead of href2 being a plain text

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy force-pushed the backport/8449/stable8 branch from cd4524b to 218eaf4 Compare April 23, 2026 12:27
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
…' dependency

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
- essentially it's the same visitor underneath, just allow access all parents stack (ancestor)

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy force-pushed the backport/8449/stable8 branch from 218eaf4 to 806dad4 Compare April 23, 2026 12:46
@Antreesy Antreesy marked this pull request as ready for review April 23, 2026 12:47
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 46.64%. Comparing base (329ad3e) to head (806dad4).
⚠️ Report is 11 commits behind head on stable8.

Additional details and impacted files
@@             Coverage Diff             @@
##           stable8    #8465      +/-   ##
===========================================
+ Coverage    46.53%   46.64%   +0.10%     
===========================================
  Files          194      194              
  Lines         4891     4901      +10     
  Branches      1263     1265       +2     
===========================================
+ Hits          2276     2286      +10     
  Misses        2527     2527              
  Partials        88       88              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on deployed preview (nested md links, placeholders, code blocks)

@Antreesy Antreesy merged commit ed7419b into stable8 Apr 23, 2026
21 checks passed
@Antreesy Antreesy deleted the backport/8449/stable8 branch April 23, 2026 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug Something isn't working feature: richtext Related to the richtext component

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants