Skip to content

fix(NcDateTimePicker): improve some usability issues#8479

Open
GVodyanov wants to merge 1 commit intomainfrom
fix/datepicker-usability
Open

fix(NcDateTimePicker): improve some usability issues#8479
GVodyanov wants to merge 1 commit intomainfrom
fix/datepicker-usability

Conversation

@GVodyanov
Copy link
Copy Markdown
Contributor

Fixes a few small issues:

  • Selected offset/disabled days now have white text color
  • Added icon to submit button
  • Fixed scrolling through the months. Previously horizontal scroll made it go to the past, and vertical to the future, which is really weird. Now scrolling to left/right goes past/present.

🖼️ Screenshots

🏚️ Before 🏡 After
image image
image image

🚧 Tasks

  • ...

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 2️⃣ Backport to stable8 for maintained Vue 2 version or not applicable

@GVodyanov GVodyanov self-assigned this Apr 28, 2026
@GVodyanov GVodyanov added the 3. to review Waiting for reviews label Apr 28, 2026
@GVodyanov GVodyanov force-pushed the fix/datepicker-usability branch from 8bb1b77 to 785aa4a Compare April 28, 2026 18:35
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 28, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 54.55%. Comparing base (034beb5) to head (58cbf03).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8479   +/-   ##
=======================================
  Coverage   54.55%   54.55%           
=======================================
  Files         106      106           
  Lines        3439     3439           
  Branches     1002     1003    +1     
=======================================
  Hits         1876     1876           
  Misses       1322     1322           
  Partials      241      241           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown

@SebastianKrupinski SebastianKrupinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Signed-off-by: Grigory V <scratchx@gmx.com>
@GVodyanov GVodyanov force-pushed the fix/datepicker-usability branch from c8041c7 to 58cbf03 Compare April 28, 2026 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants