Skip to content

feat(NcPopover): expose distance and skidding props#8484

Open
pringelmann wants to merge 1 commit intomainfrom
feat/ncpopover-distance-skidding
Open

feat(NcPopover): expose distance and skidding props#8484
pringelmann wants to merge 1 commit intomainfrom
feat/ncpopover-distance-skidding

Conversation

@pringelmann
Copy link
Copy Markdown
Contributor

floating-vue's <Dropdown> accepts distance and skidding for nudging the popper relative to the trigger. NcPopover hardcodes distance to 10 and never passes skidding through, so consumers can't shift a popover without CSS hacks that confuse the positioning math. Defaults are preserved, so this is non-breaking.

Resolves

Needed for the redesigned app launcher in nextcloud/server#59888.

Screenshots

No visual change with defaults.

Tasks

  • Add distance and skidding props
  • Forward both to <Dropdown>

Checklist

  • Tests included or not applicable: not applicable. Defaults match the previous hardcoded values, so existing tests still cover the default path.
  • Component documentation extended/updated or not applicable: prop JSDoc added, styleguidist picks it up automatically.
  • Backport to stable8 for Vue 2 or not applicable: additive and non-breaking. Happy to backport if needed.

-e
Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com>
@pringelmann pringelmann added this to the 9.7.0 milestone Apr 30, 2026
@pringelmann pringelmann requested review from skjnldsv and susnux April 30, 2026 07:09
@pringelmann pringelmann self-assigned this Apr 30, 2026
@pringelmann pringelmann added enhancement New feature or request 3. to review Waiting for reviews labels Apr 30, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 30, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 54.55%. Comparing base (034beb5) to head (1f07966).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8484   +/-   ##
=======================================
  Coverage   54.55%   54.55%           
=======================================
  Files         106      106           
  Lines        3439     3439           
  Branches     1002     1003    +1     
=======================================
  Hits         1876     1876           
  Misses       1322     1322           
  Partials      241      241           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Antreesy Antreesy modified the milestones: 9.7.0, 9.7.1 Apr 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants