[stable8] feat(NcAppSidebarTab): Redesign active tab as rounded filled pill#8501
Open
[stable8] feat(NcAppSidebarTab): Redesign active tab as rounded filled pill#8501
Conversation
The active sidebar tab now renders as a rounded surface backed by a neutral hover-tone fill, with a wide rounded indicator that grows into place when selected. The icon slot now receives the active state so consumers can render filled/outlined icon variants. Backport of #8447 to stable8. Signed-off-by: nfebe <fenn25.fn@gmail.com>
nfebe
added
3. to review
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## stable8 #8501 +/- ##
===========================================
+ Coverage 46.53% 46.84% +0.30%
===========================================
Files 194 195 +1
Lines 4891 4921 +30
Branches 1201 1268 +67
===========================================
+ Hits 2276 2305 +29
+ Misses 2529 2528 -1
- Partials 86 88 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
susnux
requested changes
May 5, 2026
Contributor
susnux
left a comment
susnux
left a comment
There was a problem hiding this comment.
where is the legacy fallback?
ShGKme
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The active sidebar tab now renders as a rounded surface backed by a neutral hover-tone fill, with a wide rounded indicator that grows into place when selected. The icon slot now receives the active state so consumers can render filled/outlined icon variants.
Backport of #8447 to stable8.