Skip to content

fix(NcSettingsSection): clear NcAppNavigation toggle overhang #8554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pringelmann wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −1
Open

fix(NcSettingsSection): clear NcAppNavigation toggle overhang #8554

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/components/NcSettingsSection/NcSettingsSection.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,12 +108,18 @@ const ariaLabel = t('External documentation')
<style lang="scss" scoped>
$maxWidth: 900px;
$sectionMargin: calc(var(--default-grid-baseline) * 7);
// Clear the NcAppNavigation toggle overhang on the inline-start edge.
$sectionMarginStart: max(
#{$sectionMargin},
calc(var(--app-navigation-padding) + var(--default-clickable-area) + var(--default-grid-baseline) * 2)
Copy link
Copy Markdown
Contributor

@susnux susnux May 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we want this then this at least looks a bit uneven to me, most apps I know handle it with:

Suggested change
calc(var(--app-navigation-padding) + var(--default-clickable-area) + var(--default-grid-baseline) * 2)
calc(2 * var(--app-navigation-padding) + var(--default-clickable-area))

);

.settings-section {
display: block;
padding: 0 0 calc(var(--default-grid-baseline) * 5) 0;
margin: $sectionMargin;
width: min($maxWidth, 100% - calc($sectionMargin * 2));
margin-inline-start: $sectionMarginStart;
width: min($maxWidth, 100% - #{$sectionMarginStart} - $sectionMargin);

&:not(:last-child) {
border-bottom: 1px solid var(--color-border);
Expand Down
Loading