[stable8] fix(NcAppSettingsDialog): Polish dialog navigation and close button#8593
Open
nfebe wants to merge 3 commits into
Open
[stable8] fix(NcAppSettingsDialog): Polish dialog navigation and close button#8593nfebe wants to merge 3 commits into
nfebe wants to merge 3 commits into
Conversation
The dialog's navigation sidebar now mirrors the main app navigation: - Hovering an item and switching the selected item animate smoothly instead of snapping. - The selection pill matches the regular navigation height, so it no longer clips into the rounded corners of the item. Refs #8526 Signed-off-by: nfebe <fenn25.fn@gmail.com>
The close button now sits on a tinted surface, so content scrolling underneath no longer bleeds through behind it. Refs #8526 Signed-off-by: nfebe <fenn25.fn@gmail.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## stable8 #8593 +/- ##
========================================
Coverage 46.85% 46.85%
========================================
Files 195 195
Lines 4926 4926
Branches 1205 1205
========================================
Hits 2308 2308
Misses 2531 2531
Partials 87 87 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
On the NC 34+ design, the collapse chevron of an active item with sub-sections was rendering white on a lightly tinted background and its hover state inherited legacy colors. The parent now forces the chevron icon to use the main text color so it stays readable, and the chevron's legacy hover backgrounds are scoped to legacy only, so on the new design the chevron picks up the tertiary button hover tint and looks consistent across active and idle items. Refs #8526 Signed-off-by: nfebe <fenn25.fn@gmail.com>
Contributor
|
What about main? |
Contributor
Author
We can backport from here once approved. |
jancborchardt
left a comment
jancborchardt
left a comment
Contributor
There was a problem hiding this comment.
Looks good, but I would say the close button should have color-main-background rather than being tinted, as the tint calls too much attention to the button.
susnux
reviewed
Jun 3, 2026
kra-mo
approved these changes
Jun 4, 2026
kra-mo
left a comment
kra-mo
left a comment
Member
There was a problem hiding this comment.
Looks good from the screenshots aside from the close button background. I would also like to see how the animations look though. Could you attach a screen recording?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the remaining Settings Dialog follow-ups from #8526:
🖼️ Screenshots