Skip to content

[stable8] fix(NcAppSettingsDialog): Polish dialog navigation and close button #8593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nfebe wants to merge 3 commits into
base: stable8
Choose a base branch
from
+29 −3
Open

[stable8] fix(NcAppSettingsDialog): Polish dialog navigation and close button #8593

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5afc861
fix(NcAppSettingsDialog): Animate sidebar and align selection pill
nfebe Jun 2, 2026
425e7ab
fix(NcAppSettingsDialog): Give the close button a background
nfebe Jun 2, 2026
783dd8c
fix(NcAppNavigationItem): Polish active collapse chevron on new design
nfebe Jun 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/assets/NcAppNavigationItem.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,10 @@
}
}

:deep(.icon-collapse) {
color: var(--color-main-text) !important;
}

&:not(.app-navigation-entry--editing)::before {
content: '';
position: absolute;
Expand Down
4 changes: 2 additions & 2 deletions src/components/NcAppNavigationItem/NcAppNavigationIconCollapsible.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,10 +87,10 @@ export default {
inset-inline-end: 0;

// the whole navigation item is hovered thus will have the hover color - to distinguish we need to set a different color here.
&:hover {
&.button-vue--legacy34:hover {
background-color: var(--color-background-dark) !important;
}
&--active:hover {
&--active.button-vue--legacy34:hover {
background-color: var(--color-primary-element) !important;
}
}
Expand Down
24 changes: 23 additions & 1 deletion src/components/NcAppSettingsDialog/NcAppSettingsDialog.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,6 +278,15 @@ $content-inset: calc(3 * var(--default-grid-baseline));
max-width: 900px;
}

:deep(.modal-container__close) {
background-color: var(--color-primary-element-light) !important;
Comment thread
nfebe marked this conversation as resolved.

&:hover,
&:focus-visible {
background-color: var(--color-primary-element-light-hover) !important;
}
}

:deep(.dialog__name) {
position: absolute;
width: 1px;
Expand Down Expand Up @@ -342,6 +351,7 @@ $content-inset: calc(3 * var(--default-grid-baseline));
background-color: transparent;
border: none;
color: var(--color-main-text);
transition: background-color var(--animation-quick, 200ms) ease-in-out;

&:hover,
&:focus-visible {
Expand All @@ -364,11 +374,12 @@ $content-inset: calc(3 * var(--default-grid-baseline));
&::before {
content: '';
position: absolute;
inset-block: var(--default-grid-baseline);
inset-block: calc(var(--default-grid-baseline, 4px) * 2);
inset-inline-start: 0;
width: 3px;
background-color: var(--color-primary-element);
border-radius: 999px;
animation: nc-settings-pill-in var(--animation-quick, 200ms) ease-out;
}
}

Expand Down Expand Up @@ -475,6 +486,17 @@ $content-inset: calc(3 * var(--default-grid-baseline));
}
}
}

@keyframes nc-settings-pill-in {
from {
transform: scaleY(0);
opacity: 0;
}
to {
transform: scaleY(1);
opacity: 1;
}
}
</style>

<docs>
Expand Down
Loading