fix(NcEllipsisedOption): make sure accessible name is properly computed#8670
Open
susnux wants to merge 1 commit into
Open
fix(NcEllipsisedOption): make sure accessible name is properly computed#8670susnux wants to merge 1 commit into
susnux wants to merge 1 commit into
Conversation
The component uses `display: flex` and then splits a string, e.g. "longvaluename" is split like "'longva' 'luname'". Because of `display: flex` this is considered two different strings instead of one, so the accessible name is now: "longva luname" If `display: inline` is used its calculated correctly, but even with `inline-flex` it does not work as browsers still consider this now two elements instead of one inline. The solution is to hide the visual separated elements from the accessibility tree and use a non-visual element that just contains the full name. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8670 +/- ##
=======================================
Coverage 54.06% 54.06%
=======================================
Files 106 106
Lines 3479 3479
Branches 1008 1008
=======================================
Hits 1881 1881
Misses 1354 1354
Partials 244 244 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
ShGKme
reviewed
Jun 25, 2026
ShGKme
left a comment
ShGKme
left a comment
Contributor
There was a problem hiding this comment.
Does it mean, the highlighting itself is not accessible anymore (hidden)?
Contributor
Author
From accessibility tree yes. This is more of a RFC, I am not sure if:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
The component uses
display: flexand then splits a string, e.g. "longvaluename" is split like "'longva' 'luname'". Because ofdisplay: flexthis is considered two different strings instead of one, so the accessible name is now: "longva luname"If
display: inlineis used its calculated correctly, but even withinline-flexit does not work as browsers still consider this now two elements instead of one inline.The solution is to hide the visual separated elements from the accessibility tree and use a non-visual element that just contains the full name.
🏁 Checklist
stable8for maintained Vue 2 version or not applicable