fix(NcAppNavigationItem): close mobile navigation on router-link click#8732
Open
jancborchardt wants to merge 1 commit into
Open
fix(NcAppNavigationItem): close mobile navigation on router-link click#8732jancborchardt wants to merge 1 commit into
jancborchardt wants to merge 1 commit into
Conversation
fix #2523 Assisted-by: ClaudeCode:claude-opus-4-8 Signed-off-by: Jan C. Borchardt <925062+jancborchardt@users.noreply.github.com>
jancborchardt
requested review from
ShGKme,
kra-mo,
marcoambrosini,
nimishavijay and
susnux
jancborchardt
added
bug
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8732 +/- ##
==========================================
- Coverage 53.10% 52.40% -0.71%
==========================================
Files 106 109 +3
Lines 3544 3685 +141
Branches 1022 1077 +55
==========================================
+ Hits 1882 1931 +49
- Misses 1406 1491 +85
- Partials 256 263 +7 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
marcoambrosini
approved these changes
Jul 14, 2026
marcoambrosini
left a comment
marcoambrosini
left a comment
Contributor
There was a problem hiding this comment.
agreed! Very nice :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On narrower screen sizes, when the app-navigation is overlaid over the content and can be toggled, clicking on any folder/mailbox to open it keeps the app-navigation open which results in it overlaying the message list. Instead, clicking on any folder/mailbox in the app-navigation should close the app-navigation.
This is an issue in Files, Activity, Photos, Mail, Contacts, Calendar, Notes, Deck, Tables, Office, and probably more apps.
In Talk, Collectives and Forms, the issue does not occur cause custom fixes were used.
This is an annoyance in every app, hence solving it on the components level makes most sense.
☑️ Resolves
🖼️ Screenshots
🏚️ Before
Screencast.From.2026-07-13.21-53-52.webm
🏡 After
Screencast.From.2026-07-13.21-53-19.webm
🏁 Checklist
stable8for maintained Vue 2 version or not applicableAssisted-by: ClaudeCode:claude-opus-4-8