Skip to content

chore: rename node to npm-build workflow #707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
susnux wants to merge 1 commit into
base: master
Choose a base branch
from
+12 −12
Open

chore: rename node to npm-build workflow #707

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions workflow-templates/node.properties.json
View file
Open in desktop

This file was deleted.

11 changes: 11 additions & 0 deletions workflow-templates/npm-build.properties.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"name": "Frontend build workflow",
"description": "Nextcloud workflow template for check frontend builds.",
"iconName": "npm-build",
"categories": [
"JavaScript"
],
"filePatterns": [
"^package.json$"
]
}
0 workflow-templates/node.svg → workflow-templates/npm-build.svg
View file
Open in desktop
File renamed without changes
2 changes: 1 addition & 1 deletion workflow-templates/node.yml → workflow-templates/npm-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
# SPDX-FileCopyrightText: 2021-2024 Nextcloud GmbH and Nextcloud contributors
# SPDX-License-Identifier: MIT

name: Node
Copy link
Copy Markdown
Contributor

@ShGKme ShGKme Apr 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about #667 (comment) ?

Copy link
Copy Markdown
Member

@nickvergessen nickvergessen Apr 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the name here is fine, just the summary name must not change.
We could simply try it in an app with compiled assets.

The problematic part is that everyone updates workflows by copying them files misisng files are skipped.
I think we should keep a node.yml for some time that simply makes red CI and tells you to use npm-build.yml going forward

name: Build Javascript

on: pull_request

Expand Down
Loading