fix: report bytes_freed=0 when image_remove only untags a multi-tagged image

Signed-off-by: Oleksander Piskun <oleksandr2088@icloud.com>

Author: oleksandr-nc

haproxy_agent.py

@@ -1539,8 +1539,29 @@ async def docker_exapp_image_remove(request: web.Request):
         try:
             async with session.delete(delete_url) as resp:
                 if resp.status == 200:
-                    LOGGER.info("Image '%s' removed (%d bytes freed).", image_ref, bytes_freed)
-                    return web.json_response({"deleted": True, "bytes_freed": bytes_freed})
+                    # Docker returns a JSON array describing what happened, e.g.
+                    #   [{"Untagged": "..."}, {"Deleted": "sha256:..."}]
+                    # If the image had more than one tag, only the requested tag is
+                    # untagged and the underlying image stays on disk. In that case
+                    # no bytes were actually freed even though Docker says 200, so we
+                    # report bytes_freed=0 instead of the inspected size — otherwise
+                    # multi-tagged images would inflate the "space reclaimed" numbers
+                    # admins see in the logs.
+                    try:
+                        ops = await resp.json()
+                    except (json.JSONDecodeError, aiohttp.ContentTypeError):
+                        ops = []
+                    actually_deleted = isinstance(ops, list) and any(
+                        isinstance(op, dict) and "Deleted" in op for op in ops
+                    )
+                    actual_bytes_freed = bytes_freed if actually_deleted else 0
+                    LOGGER.info(
+                        "Image '%s' removed (deleted=%s, bytes_freed=%d).",
+                        image_ref,
+                        actually_deleted,
+                        actual_bytes_freed,
+                    )
+                    return web.json_response({"deleted": True, "bytes_freed": actual_bytes_freed})
                 if resp.status == 404:
                     LOGGER.info("Image '%s' already gone at delete time.", image_ref)
                     return web.json_response({"deleted": True, "bytes_freed": 0, "reason": "not_found"})