fix: explicit set /exapps/ in NGINX example; don't blacklist trusted callers#100
Open
oleksandr-nc wants to merge 1 commit intomainfrom
Open
fix: explicit set /exapps/ in NGINX example; don't blacklist trusted callers#100oleksandr-nc wants to merge 1 commit intomainfrom
/exapps/ in NGINX example; don't blacklist trusted callers#100oleksandr-nc wants to merge 1 commit intomainfrom
Conversation
Signed-off-by: Oleksander Piskun <oleksandr2088@icloud.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #57
README NGINX example - explicit
/exapps/pathDon't blacklist trusted callers
Added
record_failure_unless_trusted()helper that skips blacklist accounting when the request carries a harp-shared-key matching HP_SHARED_KEYApplied at the two failure sites legitimate Nextcloud/AppAPI callers can trip on:
Rationale: a reverse-proxy misconfiguration (issue 1) would otherwise cause Nextcloud's own cron heartbeats to accumulate failures against 127.0.0.1 and eventually blacklist the NC server from HaRP entirely - a self-DoS.