debug: add logging to docs PR step and fix skip logic

- Split into check step + run step to avoid secrets-in-if issue
- Add detailed logging with ::group:: sections for each phase
- Re-add push trigger for testing

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: miaulalala

.github/workflows/screenshots.yml

@@ -4,6 +4,7 @@
 name: Documentation Screenshots
 
 on:
+  push: # TODO: remove before merging — temporary trigger for CI testing
   workflow_dispatch:
     inputs:
       server-branch:
@@ -94,35 +95,75 @@ jobs:
       # Opens a PR against nextcloud/documentation with updated screenshots.
       # Uses the org-wide COMMAND_BOT_PAT secret.
       # The step is skipped gracefully if the secret is not configured.
+      - name: Check if docs PR should be created
+        id: docs-pr-check
+        env:
+          COMMAND_BOT_PAT: ${{ secrets.COMMAND_BOT_PAT }}
+          OPEN_DOCS_PR: ${{ inputs.open-docs-pr }}
+        run: |
+          echo "::group::Debug info"
+          echo "inputs.open-docs-pr = '${OPEN_DOCS_PR}'"
+          echo "COMMAND_BOT_PAT is set = $([ -n "$COMMAND_BOT_PAT" ] && echo 'yes' || echo 'no')"
+          echo "event_name = ${{ github.event_name }}"
+          echo "::endgroup::"
+
+          if [ -z "$COMMAND_BOT_PAT" ]; then
+            echo "COMMAND_BOT_PAT is not set, skipping docs PR."
+            echo "should_run=false" >> "$GITHUB_OUTPUT"
+          elif [ "$OPEN_DOCS_PR" = "false" ]; then
+            echo "open-docs-pr is false, skipping docs PR."
+            echo "should_run=false" >> "$GITHUB_OUTPUT"
+          else
+            echo "Will attempt to create docs PR."
+            echo "should_run=true" >> "$GITHUB_OUTPUT"
+          fi
+
       - name: Open PR against nextcloud/documentation
-        if: inputs.open-docs-pr != false && env.COMMAND_BOT_PAT != ''
+        if: steps.docs-pr-check.outputs.should_run == 'true'
         env:
           COMMAND_BOT_PAT: ${{ secrets.COMMAND_BOT_PAT }}
         run: |
+          set -e
           DOCS_BRANCH="chore/activity-screenshots-$(date +%Y%m%d-%H%M%S)"
           SCREENSHOT_DIR="cypress/snapshots/actual/screenshots.cy.ts"
 
-          # Clone the documentation repo using the PAT
+          echo "::group::Clone documentation repo"
           git clone --depth 1 "https://x-access-token:${COMMAND_BOT_PAT}@github.com/nextcloud/documentation.git" /tmp/documentation
           cd /tmp/documentation
+          echo "Clone successful"
+          echo "::endgroup::"
 
           git config user.name "nextcloud-command"
           git config user.email "nextcloud-command@users.noreply.github.com"
           git checkout -b "$DOCS_BRANCH"
 
+          echo "::group::Copy screenshots"
           # Copy user screenshots
           if [ -d "$GITHUB_WORKSPACE/$SCREENSHOT_DIR/user" ]; then
+            echo "User screenshot files:"
+            ls -la "$GITHUB_WORKSPACE/$SCREENSHOT_DIR/user/"
             cp "$GITHUB_WORKSPACE/$SCREENSHOT_DIR/user/"*.png user_manual/images/
-            echo "Copied user screenshots"
+            echo "Copied user screenshots to user_manual/images/"
+          else
+            echo "WARNING: No user screenshot directory found at $GITHUB_WORKSPACE/$SCREENSHOT_DIR/user"
           fi
 
           # Copy admin screenshots
           if [ -d "$GITHUB_WORKSPACE/$SCREENSHOT_DIR/admin" ]; then
+            echo "Admin screenshot files:"
+            ls -la "$GITHUB_WORKSPACE/$SCREENSHOT_DIR/admin/"
             cp "$GITHUB_WORKSPACE/$SCREENSHOT_DIR/admin/"*.png admin_manual/images/
-            echo "Copied admin screenshots"
+            echo "Copied admin screenshots to admin_manual/images/"
+          else
+            echo "WARNING: No admin screenshot directory found at $GITHUB_WORKSPACE/$SCREENSHOT_DIR/admin"
           fi
+          echo "::endgroup::"
 
           # Check if there are changes to commit
+          echo "::group::Git status"
+          git status
+          echo "::endgroup::"
+
           if git diff --quiet && [ -z "$(git ls-files --others --exclude-standard)" ]; then
             echo "No screenshot changes detected, skipping PR."
             exit 0
@@ -135,10 +176,15 @@ jobs:
             PR_TITLE="chore: update activity app screenshots"
           fi
 
+          echo "::group::Commit and push"
           git add user_manual/images/activity-*.png admin_manual/images/activity-*.png
+          git diff --cached --stat
           git commit -m "$PR_TITLE"
           git push origin "$DOCS_BRANCH"
+          echo "Pushed branch $DOCS_BRANCH"
+          echo "::endgroup::"
 
+          echo "::group::Create PR"
           # Create the PR
           GH_TOKEN="${COMMAND_BOT_PAT}" gh pr create \
             --repo nextcloud/documentation \
@@ -160,6 +206,7 @@ jobs:
           Generated automatically by the Activity app [screenshot workflow](https://github.com/nextcloud/activity/actions/workflows/screenshots.yml).
           EOF
           )"
+          echo "::endgroup::"
 
           echo "PR created successfully"