fix(psalm): remove redundant casts and dead is_string guard after native types

Agent-Logs-Url: https://github.com/nextcloud/activity/sessions/e9a877c2-92db-4439-b35e-27e0ba15f897

Co-authored-by: miaulalala <7427347+miaulalala@users.noreply.github.com>

Author: Copilot

lib/Controller/APIv2Controller.php

@@ -60,15 +60,15 @@ public function __construct(
 	 * @throws \OutOfBoundsException when no user is given
 	 */
 	protected function validateParameters(string $filter, int $since, int $limit, bool $previews, string $objectType, int $objectId, string $sort): void {
-		$this->filter = \is_string($filter) ? $filter : 'all';
+		$this->filter = $filter;
 		if ($this->filter !== $this->data->validateFilter($this->filter)) {
 			throw new InvalidFilterException('Invalid filter');
 		}
-		$this->since = (int)$since;
-		$this->limit = (int)$limit;
-		$this->loadPreviews = (bool)$previews;
-		$this->objectType = (string)$objectType;
-		$this->objectId = (int)$objectId;
+		$this->since = $since;
+		$this->limit = $limit;
+		$this->loadPreviews = $previews;
+		$this->objectType = $objectType;
+		$this->objectId = $objectId;
 		$this->sort = \in_array($sort, ['asc', 'desc'], true) ? $sort : 'desc';
 
 		if (($this->objectType !== '' && $this->objectId === 0) || ($this->objectType === '' && $this->objectId !== 0)) {

lib/Data.php

@@ -331,7 +331,7 @@ protected function setOffsetFromSince(IQueryBuilder $query, string $user, int $s
 		$queryBuilder = $this->connection->getQueryBuilder();
 		$queryBuilder->select(['affecteduser', 'timestamp'])
 			->from('activity')
-			->where($queryBuilder->expr()->eq('activity_id', $queryBuilder->createNamedParameter((int)$since)));
+			->where($queryBuilder->expr()->eq('activity_id', $queryBuilder->createNamedParameter($since)));
 		$result = $queryBuilder->executeQuery();
 		$activity = $result->fetch();
 		$result->closeCursor();