fix(expire): delete conditions for activity_expire_exclude_users#2655
Merged
Conversation
artonge
approved these changes
Jun 24, 2026
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
miaulalala
force-pushed
the
fix/correct-delete-conditions
branch
from
July 15, 2026 19:52
ecb0b15 to
61423f9
Compare
Collaborator
|
/backport to stable34 |
Collaborator
|
/backport to stable33 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #2647
I truly believe this config param never worked since it has been shipped...
Build delete conditions as
[column, value, operator]tuples and apply them all withandWhere()via a shared helper, fixing the crash whenactivity_expire_exclude_usersis set and the MySQL chunked-delete path dropping all but the last condition.🤖 AI (if applicable)