Merge pull request #1236 from nextcloud/dependabot/gradle/com.github.spotbugs.snom-spotbugs-gradle-plugin-5.2.2

Bump com.github.spotbugs.snom:spotbugs-gradle-plugin from 5.2.1 to 5.2.2

Author: AndyScherzinger

library/build.gradle

@@ -6,7 +6,7 @@ buildscript {
     }
     dependencies {
         classpath 'com.android.tools.build:gradle:8.1.2'
-        classpath 'com.github.spotbugs.snom:spotbugs-gradle-plugin:5.2.1'
+        classpath 'com.github.spotbugs.snom:spotbugs-gradle-plugin:5.2.2'
         classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlin_version"
         classpath "io.gitlab.arturbosch.detekt:detekt-gradle-plugin:1.23.3"
         classpath "org.jacoco:org.jacoco.core:$jacoco_version"

library/src/androidTest/java/com/nextcloud/android/lib/resources/files/ToggleFileLockRemoteOperationIT.kt

@@ -39,7 +39,6 @@ import org.junit.Assert.assertTrue
 import org.junit.Test
 
 class ToggleFileLockRemoteOperationIT : AbstractIT() {
-
     @Test
     fun lockUnlockFile() {
         // only on >= NC24

library/src/androidTest/java/com/nextcloud/android/lib/resources/profile/GetHoverCardRemoteOperationIT.kt

@@ -41,8 +41,9 @@ class GetHoverCardRemoteOperationIT : AbstractIT() {
 
     @Test
     fun testHoverCard() {
-        val result = GetHoverCardRemoteOperation(nextcloudClient.userId)
-            .execute(nextcloudClient)
+        val result =
+            GetHoverCardRemoteOperation(nextcloudClient.userId)
+                .execute(nextcloudClient)
         assertTrue(result.logMessage, result.isSuccess)
         val hoverCard = result.resultData
         assertEquals(nextcloudClient.userId, hoverCard?.userId)

library/src/androidTest/java/com/nextcloud/android/lib/resources/search/SearchProvidersRemoteOperationIT.kt

@@ -53,8 +53,9 @@ class SearchProvidersRemoteOperationIT : AbstractIT() {
     @Test
     fun getSearchProvidersOnOldServer() {
         // only on < NC20
-        val ocCapability = GetCapabilitiesRemoteOperation()
-            .execute(nextcloudClient).singleData as OCCapability
+        val ocCapability =
+            GetCapabilitiesRemoteOperation()
+                .execute(nextcloudClient).singleData as OCCapability
         assumeTrue(
             ocCapability.version.isOlderThan(OwnCloudVersion.nextcloud_20)
         )

library/src/androidTest/java/com/nextcloud/android/lib/resources/search/UnifiedSearchRemoteOperationIT.kt

@@ -60,8 +60,9 @@ class UnifiedSearchRemoteOperationIT : AbstractIT() {
     fun filesSearch() {
         val remotePath = "/testFolder"
         assertTrue(CreateFolderRemoteOperation(remotePath, true).execute(client).isSuccess)
-        val remoteFile = ReadFileRemoteOperation(remotePath)
-            .execute(client).data[0] as RemoteFile
+        val remoteFile =
+            ReadFileRemoteOperation(remotePath)
+                .execute(client).data[0] as RemoteFile
         val fileId = remoteFile.localId
 
         val result = UnifiedSearchRemoteOperation("files", "test").execute(nextcloudClient)

library/src/androidTest/java/com/nextcloud/common/NextcloudUriDelegateIT.kt

@@ -6,7 +6,6 @@ import org.junit.Before
 import org.junit.Test
 
 class NextcloudUriDelegateIT {
-
     lateinit var sut: NextcloudUriDelegate
 
     @Before

library/src/androidTest/java/com/owncloud/android/RetryTestRule.kt

@@ -31,19 +31,20 @@ import org.junit.runners.model.Statement
  * C&p from https://stackoverflow.com/questions/45635833/how-can-i-use-flakytest-annotation-now on 18.03.2020
  */
 class RetryTestRule(val retryCount: Int = 1) : TestRule {
-
     companion object {
         private val TAG = RetryTestRule::class.java.simpleName
     }
 
-    override fun apply(base: Statement, description: Description): Statement {
+    override fun apply(
+        base: Statement,
+        description: Description
+    ): Statement {
         return statement(base, description)
     }
 
     @Suppress("TooGenericExceptionCaught") // and this exactly what we want here
     private fun statement(base: Statement, description: Description): Statement {
         return object : Statement() {
-
             override fun evaluate() {
                 Log.e(TAG, "Evaluating ${description.methodName}")
 

library/src/androidTest/java/com/owncloud/android/lib/common/OwnCloudClientTest.kt

@@ -36,11 +36,12 @@ import org.junit.Test
 class OwnCloudClientTest : AbstractIT() {
     @Test
     fun testUri() {
-        val client = OwnCloudClientFactory.createOwnCloudClient(
-            Uri.parse("https://10.0.2.2/nc"),
-            context,
-            false
-        )
+        val client =
+            OwnCloudClientFactory.createOwnCloudClient(
+                Uri.parse("https://10.0.2.2/nc"),
+                context,
+                false
+            )
         client.userId = "test"
 
         assertEquals(
@@ -57,24 +58,26 @@ class OwnCloudClientTest : AbstractIT() {
 
     @Test
     fun testUserId() {
-        val client = OwnCloudClientFactory.createOwnCloudClient(
-            Uri.parse("https://10.0.2.2/nc"),
-            context,
-            false
-        )
+        val client =
+            OwnCloudClientFactory.createOwnCloudClient(
+                Uri.parse("https://10.0.2.2/nc"),
+                context,
+                false
+            )
 
         val credentials = basic("user", "password")
         val nextcloudClient = NextcloudClient(url, "user", credentials, context)
 
-        val testList = listOf(
-            Pair("test@test.de", "test@test.de"),
-            Pair("Test User", "Test%20User"),
-            Pair("test", "test"),
-            Pair("test+test@test.localhost", "test+test@test.localhost"),
-            Pair("test - ab4c", "test%20-%20ab4c"),
-            Pair("test.-&51_+-?@test.localhost", "test.-%2651_+-%3F@test.localhost"),
-            Pair("test'ab4c", "test%27ab4c")
-        )
+        val testList =
+            listOf(
+                Pair("test@test.de", "test@test.de"),
+                Pair("Test User", "Test%20User"),
+                Pair("test", "test"),
+                Pair("test+test@test.localhost", "test+test@test.localhost"),
+                Pair("test - ab4c", "test%20-%20ab4c"),
+                Pair("test.-&51_+-?@test.localhost", "test.-%2651_+-%3F@test.localhost"),
+                Pair("test'ab4c", "test%27ab4c")
+            )
 
         testList.forEach { pair ->
             client.userId = pair.first

library/src/androidTest/java/com/owncloud/android/lib/common/SearchResultEntryTest.kt

@@ -26,7 +26,6 @@ import org.junit.Assert.assertEquals
 import org.junit.Test
 
 class SearchResultEntryTest {
-
     @Test
     fun testFilePath() {
         val sut = SearchResultEntry()
@@ -73,7 +72,10 @@ class SearchResultEntryTest {
         )
     }
 
-    private fun setPath(path: String, entry: SearchResultEntry): String? {
+    private fun setPath(
+        path: String,
+        entry: SearchResultEntry
+    ): String? {
         entry.resourceUrl = path
 
         return entry.remotePath()

library/src/androidTest/java/com/owncloud/android/lib/common/UsernameVariationsIT.kt

@@ -39,11 +39,12 @@ class UsernameVariationsIT(private val username: String) : AbstractIT() {
     companion object {
         @Parameterized.Parameters(name = "{0}")
         @JvmStatic
-        fun data(): Collection<Array<Any>> = listOf(
-            arrayOf("test"),
-            arrayOf("test test"),
-            arrayOf("test@test")
-        )
+        fun data(): Collection<Array<Any>> =
+            listOf(
+                arrayOf("test"),
+                arrayOf("test test"),
+                arrayOf("test@test")
+            )
     }
 
     @Test