Merge pull request #1967 from nextcloud/editTags

Delete Tags

Author: alperozturk96

library/src/androidTest/java/com/owncloud/android/lib/resources/tags/DeleteTagRemoteOperationIT.kt

@@ -0,0 +1,80 @@
+/*
+ * Nextcloud Android Library
+ *
+ * SPDX-FileCopyrightText: 2026 Nextcloud GmbH and Nextcloud contributors
+ * SPDX-License-Identifier: MIT
+ */
+package com.owncloud.android.lib.resources.tags
+
+import com.nextcloud.test.RandomStringGenerator
+import com.owncloud.android.AbstractIT
+import com.owncloud.android.lib.resources.files.CreateFolderRemoteOperation
+import com.owncloud.android.lib.resources.files.ReadFileRemoteOperation
+import com.owncloud.android.lib.resources.files.ReadFolderRemoteOperation
+import com.owncloud.android.lib.resources.files.model.RemoteFile
+import com.owncloud.android.lib.resources.status.NextcloudVersion
+import junit.framework.TestCase.assertEquals
+import junit.framework.TestCase.assertTrue
+import org.junit.Test
+
+class DeleteTagRemoteOperationIT : AbstractIT() {
+    companion object {
+        const val TAG_LENGTH = 10
+    }
+
+    @Test
+    fun deleteTag() {
+        testOnlyOnServer(NextcloudVersion.nextcloud_31)
+
+        // create a folder
+        val folder = "/deleteTagFolder/"
+        assertTrue(CreateFolderRemoteOperation(folder, true).execute(client).isSuccess)
+        val folderMetadata = ReadFileRemoteOperation(folder).execute(client)
+        val fileId = (folderMetadata.data[0] as RemoteFile).localId
+
+        // create a tag
+        val tagName = RandomStringGenerator.make(TAG_LENGTH)
+        assertTrue(
+            CreateTagRemoteOperation(tagName)
+                .execute(nextcloudClient)
+                .isSuccess
+        )
+
+        // find the created tag
+        val tagsResult = GetTagsRemoteOperation().execute(client)
+        assertTrue(tagsResult.isSuccess)
+        val tag = tagsResult.resultData.find { it.name == tagName }
+        assertTrue(tag != null)
+
+        // assign the tag to the folder
+        assertTrue(
+            PutTagRemoteOperation(tag!!.id, fileId)
+                .execute(nextcloudClient)
+                .isSuccess
+        )
+
+        // verify the tag is on the folder
+        var rootMetadata = ReadFolderRemoteOperation("/").execute(client)
+        var folderTags =
+            (rootMetadata.data as ArrayList<RemoteFile>)
+                .find { it.remotePath == folder }
+                ?.tags
+        assertEquals(1, folderTags?.size)
+        assertEquals(tagName, folderTags?.first()?.name)
+
+        // delete the tag from the folder
+        assertTrue(
+            DeleteTagRemoteOperation(tag.id, fileId)
+                .execute(nextcloudClient)
+                .isSuccess
+        )
+
+        // verify the tag is no longer on the folder
+        rootMetadata = ReadFolderRemoteOperation("/").execute(client)
+        folderTags =
+            (rootMetadata.data as ArrayList<RemoteFile>)
+                .find { it.remotePath == folder }
+                ?.tags
+        assertTrue(folderTags.isNullOrEmpty())
+    }
+}

library/src/main/java/com/owncloud/android/lib/resources/tags/DeleteTagRemoteOperation.kt

@@ -0,0 +1,38 @@
+/*
+ * Nextcloud Android Library
+ *
+ * SPDX-FileCopyrightText: 2026 Nextcloud GmbH and Nextcloud contributors
+ * SPDX-License-Identifier: MIT
+ */
+package com.owncloud.android.lib.resources.tags
+
+import com.nextcloud.common.NextcloudClient
+import com.nextcloud.operations.DeleteMethod
+import com.owncloud.android.lib.common.operations.RemoteOperation
+import com.owncloud.android.lib.common.operations.RemoteOperationResult
+import org.apache.commons.httpclient.HttpStatus
+
+class DeleteTagRemoteOperation(
+    val id: String,
+    val fileId: Long
+) : RemoteOperation<Void>() {
+    override fun run(client: NextcloudClient): RemoteOperationResult<Void> {
+        val deleteMethod =
+            DeleteMethod(
+                client.baseUri.toString() + TAG_URL + fileId + "/" + id,
+                true
+            )
+
+        val status = deleteMethod.execute(client)
+
+        return if (status == HttpStatus.SC_NO_CONTENT) {
+            RemoteOperationResult<Void>(true, deleteMethod)
+        } else {
+            RemoteOperationResult<Void>(false, deleteMethod)
+        }
+    }
+
+    companion object {
+        const val TAG_URL = "/remote.php/dav/systemtags-relations/files/"
+    }
+}

library/src/main/java/com/owncloud/android/lib/resources/tags/Tag.kt

@@ -7,8 +7,12 @@
  */
 package com.owncloud.android.lib.resources.tags
 
+import android.os.Parcelable
+import kotlinx.parcelize.Parcelize
+
+@Parcelize
 data class Tag(
     val id: String,
     val name: String,
     val color: String?
-)
+) : Parcelable