From c1cea595c6eab47d93451454d5006fb8b36363ed Mon Sep 17 00:00:00 2001 From: alperozturk96 Date: Wed, 17 Jun 2026 13:16:58 +0200 Subject: [PATCH 1/2] fix(e2ee): unknown value Signed-off-by: alperozturk96 --- .../owncloud/android/lib/resources/status/E2EVersion.kt | 9 +++++++-- .../android/lib/resources/status/E2EVersionTests.kt | 7 +++++++ 2 files changed, 14 insertions(+), 2 deletions(-) diff --git a/library/src/main/java/com/owncloud/android/lib/resources/status/E2EVersion.kt b/library/src/main/java/com/owncloud/android/lib/resources/status/E2EVersion.kt index 4b016e321..fafef358c 100644 --- a/library/src/main/java/com/owncloud/android/lib/resources/status/E2EVersion.kt +++ b/library/src/main/java/com/owncloud/android/lib/resources/status/E2EVersion.kt @@ -1,7 +1,8 @@ /* * Nextcloud Android Library * - * SPDX-FileCopyrightText: 2023-2024 Nextcloud GmbH and Nextcloud contributors + * SPDX-FileCopyrightText: 2023-2026 Nextcloud GmbH and Nextcloud contributors + * SPDX-FileCopyrightText: 2026 Alper Ozturk * SPDX-FileCopyrightText: 2023 Tobias Kaminsky * SPDX-License-Identifier: MIT */ @@ -19,10 +20,14 @@ enum class E2EVersion( val value: String = values.last() + var unknownValue: String? = "" + companion object { fun max(): E2EVersion = V2_1 @JvmStatic - fun fromValue(v: String?): E2EVersion = entries.find { v in it.values } ?: UNKNOWN + fun fromValue(v: String?): E2EVersion = + entries.find { v in it.values } + ?: UNKNOWN.also { it.unknownValue = v } } } diff --git a/library/src/test/java/com/owncloud/android/lib/resources/status/E2EVersionTests.kt b/library/src/test/java/com/owncloud/android/lib/resources/status/E2EVersionTests.kt index 7a4fb9c7d..904b3c65f 100644 --- a/library/src/test/java/com/owncloud/android/lib/resources/status/E2EVersionTests.kt +++ b/library/src/test/java/com/owncloud/android/lib/resources/status/E2EVersionTests.kt @@ -60,6 +60,13 @@ class E2EVersionTests { assertEquals(E2EVersion.UNKNOWN, E2EVersion.fromValue(null)) } + @Test + fun testFromValueWhenGiven3Dot0ShouldReturnTrue() { + val version = E2EVersion.fromValue("3.0") + assertEquals(E2EVersion.UNKNOWN, version) + assertEquals("3.0", version.unknownValue) + } + @Test fun testValues() { assertEquals(E2EVersion.V1_0.value, "1.0") From 604c2f367df9f29beaaba413fe0272c186d7a226 Mon Sep 17 00:00:00 2001 From: alperozturk96 Date: Wed, 17 Jun 2026 14:39:51 +0200 Subject: [PATCH 2/2] fix(e2ee): unknown value Signed-off-by: alperozturk96 --- .../com/owncloud/android/lib/resources/status/E2EVersion.kt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/library/src/main/java/com/owncloud/android/lib/resources/status/E2EVersion.kt b/library/src/main/java/com/owncloud/android/lib/resources/status/E2EVersion.kt index fafef358c..3704de7f2 100644 --- a/library/src/main/java/com/owncloud/android/lib/resources/status/E2EVersion.kt +++ b/library/src/main/java/com/owncloud/android/lib/resources/status/E2EVersion.kt @@ -20,7 +20,7 @@ enum class E2EVersion( val value: String = values.last() - var unknownValue: String? = "" + var unknownValue: String? = null companion object { fun max(): E2EVersion = V2_1