Skip to content

fix(e2ee): unknown value #2050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tobiasKaminsky merged 2 commits into from
Jun 17, 2026
+14 −2
Merged

fix(e2ee): unknown value #2050

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c1cea59
fix(e2ee): unknown value
alperozturk96 Jun 17, 2026
604c2f3
fix(e2ee): unknown value
alperozturk96 Jun 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions library/src/main/java/com/owncloud/android/lib/resources/status/E2EVersion.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
/*
* Nextcloud Android Library
*
* SPDX-FileCopyrightText: 2023-2024 Nextcloud GmbH and Nextcloud contributors
* SPDX-FileCopyrightText: 2023-2026 Nextcloud GmbH and Nextcloud contributors
* SPDX-FileCopyrightText: 2026 Alper Ozturk <alper.ozturk@nextcloud.com>
* SPDX-FileCopyrightText: 2023 Tobias Kaminsky <tobias@kaminsky.me>
* SPDX-License-Identifier: MIT
*/
Expand All @@ -19,10 +20,14 @@ enum class E2EVersion(

val value: String = values.last()

var unknownValue: String? = null

companion object {
fun max(): E2EVersion = V2_1

@JvmStatic
fun fromValue(v: String?): E2EVersion = entries.find { v in it.values } ?: UNKNOWN
fun fromValue(v: String?): E2EVersion =
entries.find { v in it.values }
?: UNKNOWN.also { it.unknownValue = v }
}
}
7 changes: 7 additions & 0 deletions library/src/test/java/com/owncloud/android/lib/resources/status/E2EVersionTests.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,13 @@ class E2EVersionTests {
assertEquals(E2EVersion.UNKNOWN, E2EVersion.fromValue(null))
}

@Test
fun testFromValueWhenGiven3Dot0ShouldReturnTrue() {
val version = E2EVersion.fromValue("3.0")
assertEquals(E2EVersion.UNKNOWN, version)
assertEquals("3.0", version.unknownValue)
}

@Test
fun testValues() {
assertEquals(E2EVersion.V1_0.value, "1.0")
Expand Down
Loading