show fail message only for download limit and check canSetDownloadLimit before updating

Signed-off-by: alperozturk <alper_ozturk@proton.me>

Author: alperozturk96

app/src/main/java/com/owncloud/android/operations/UpdateShareInfoOperation.java

@@ -79,7 +79,7 @@ protected RemoteOperationResult run(OwnCloudClient client) {
 
         if (share == null) {
             // TODO try to get remote share before failing?
-            return new RemoteOperationResult(RemoteOperationResult.ResultCode.SHARE_NOT_FOUND);
+            return new RemoteOperationResult<>(RemoteOperationResult.ResultCode.SHARE_NOT_FOUND);
         }
 
         // Update remote share
@@ -96,10 +96,10 @@ protected RemoteOperationResult run(OwnCloudClient client) {
         updateOp.setLabel(label);
         updateOp.setAttributes(attributes);
 
-        RemoteOperationResult result = updateOp.execute(client);
+        var result = updateOp.execute(client);
 
         if (result.isSuccess()) {
-            RemoteOperation getShareOp = new GetShareRemoteOperation(share.getRemoteId());
+            final var getShareOp = new GetShareRemoteOperation(share.getRemoteId());
             result = getShareOp.execute(client);
 
             //only update the share in storage if shareId is available

app/src/main/java/com/owncloud/android/ui/activity/FileActivity.java

@@ -421,8 +421,10 @@ public void onRemoteOperationFinish(RemoteOperation operation, RemoteOperationRe
             onCreateShareViaLinkOperationFinish((CreateShareViaLinkOperation) operation, result);
         } else if (operation instanceof CreateShareWithShareeOperation) {
             onUpdateShareInformation(result, R.string.sharee_add_failed);
-        } else if (operation instanceof UpdateShareViaLinkOperation || operation instanceof UpdateShareInfoOperation || operation instanceof SetFilesDownloadLimitOperation) {
+        } else if (operation instanceof UpdateShareViaLinkOperation || operation instanceof UpdateShareInfoOperation) {
             onUpdateShareInformation(result, R.string.updating_share_failed);
+        } else if (operation instanceof SetFilesDownloadLimitOperation) {
+            onUpdateShareInformation(result, R.string.set_download_limit_failed);
         } else if (operation instanceof UpdateSharePermissionsOperation) {
             onUpdateShareInformation(result, R.string.updating_share_failed);
         } else if (operation instanceof UnshareOperation) {

app/src/main/java/com/owncloud/android/ui/fragment/FileDetailsSharingProcessFragment.kt

@@ -176,7 +176,7 @@ class FileDetailsSharingProcessFragment :
 
         permission = share?.permissions
             ?: capabilities.defaultPermissions
-            ?: sharePermissionManager.getMaximumPermission(isFolder())
+                ?: sharePermissionManager.getMaximumPermission(isFolder())
     }
 
     override fun onCreateView(inflater: LayoutInflater, container: ViewGroup?, savedInstanceState: Bundle?): View {
@@ -290,7 +290,9 @@ class FileDetailsSharingProcessFragment :
         binding.run {
             when {
                 SharingMenuHelper.isUploadAndEditingAllowed(share) -> editingRadioButton.isChecked = true
-                SharingMenuHelper.isFileRequest(share) && share?.isFolder == true -> fileRequestRadioButton.isChecked = true
+                SharingMenuHelper.isFileRequest(share) && share?.isFolder == true -> fileRequestRadioButton.isChecked =
+                    true
+
                 SharingMenuHelper.isReadOnly(share) -> viewOnlyRadioButton.isChecked = true
                 else -> {
                     if (sharePermissionManager.isCustomPermission(share) ||
@@ -428,7 +430,7 @@ class FileDetailsSharingProcessFragment :
     }
 
     private fun updateFileDownloadLimitView() {
-        if (isPublicShare() && capabilities.filesDownloadLimit.isTrue && share?.isFolder == false) {
+        if (canSetDownloadLimit()) {
             binding.shareProcessSetDownloadLimitSwitch.visibility = View.VISIBLE
 
             val currentDownloadLimit = share?.fileDownloadLimit?.limit ?: capabilities.filesDownloadLimitDefault
@@ -724,7 +726,7 @@ class FileDetailsSharingProcessFragment :
             binding.shareProcessChangeName.text.toString().trim()
         )
 
-        if (capabilities.filesDownloadLimit.isTrue) {
+        if (canSetDownloadLimit()) {
             val downloadLimitInput = binding.shareProcessSetDownloadLimitInput.text.toString().trim()
             val downloadLimit =
                 if (binding.shareProcessSetDownloadLimitSwitch.isChecked && downloadLimitInput.isNotEmpty()) {
@@ -780,6 +782,9 @@ class FileDetailsSharingProcessFragment :
     // region Helpers
     private fun isFolder(): Boolean = (file?.isFolder == true || share?.isFolder == true)
 
+    private fun canSetDownloadLimit(): Boolean =
+        (isPublicShare() && capabilities.filesDownloadLimit.isTrue && share?.isFolder == false)
+
     private fun isPublicShare(): Boolean = (shareType == ShareType.PUBLIC_LINK)
     // endregion
 }

app/src/main/res/values/strings.xml

@@ -1331,6 +1331,7 @@
     <string name="re_enable_auto_upload_desc">Due to new restrictions imposed by Google, we have been forced to remove an important permission. We are currently working with Google to resolve this issue and restore full functionality.\n\nTo re-enable auto upload for new photos and videos:\nSelect \"Allow all\" in the following dialogue or the system settings.\nAllow media location when prompted, as this allows Nextcloud to store location data when uploading images.\n\nThe permissions dialogue is only displayed when necessary. If in doubt, check the system settings.\n\nAuto upload will only be able to upload image and video files when using the Google Play version of the Nextcloud app.\n\nPlease check for any files that may not have been uploaded since December 2024.</string>
     <string name="click_to_learn_how_to_re_enable_auto_uploads">Manual intervention required to re-enable auto-upload</string>
     <string name="share_download_limit">Set download limit</string>
+    <string name="set_download_limit_failed">Unable to set download limit. Please check capabilities.</string>
     <string name="download_limit">Download limit</string>
     <plurals name="share_download_limit_description">
         <item quantity="one">%1$d download remaining</item>