allow case sensitive files in same directory if wcf not enabled

Signed-off-by: alperozturk96 <alper_ozturk@proton.me>

Author: alperozturk96

app/src/main/java/com/nextcloud/client/jobs/autoUpload/AutoUploadWorker.kt

@@ -19,6 +19,7 @@ import com.nextcloud.client.database.entity.toOCUpload
 import com.nextcloud.client.database.entity.toUploadEntity
 import com.nextcloud.client.device.PowerManagementService
 import com.nextcloud.client.jobs.upload.FileUploadEventBroadcaster
+import com.nextcloud.client.jobs.upload.FileUploadHelper
 import com.nextcloud.client.jobs.upload.FileUploadWorker
 import com.nextcloud.client.jobs.utils.UploadErrorNotificationManager
 import com.nextcloud.client.network.ConnectivityService
@@ -38,8 +39,10 @@ import com.owncloud.android.lib.common.OwnCloudAccount
 import com.owncloud.android.lib.common.OwnCloudClientManagerFactory
 import com.owncloud.android.lib.common.operations.RemoteOperationResult
 import com.owncloud.android.lib.common.utils.Log_OC
+import com.owncloud.android.lib.resources.status.OCCapability
 import com.owncloud.android.operations.UploadFileOperation
 import com.owncloud.android.ui.activity.SettingsActivity
+import com.owncloud.android.utils.theme.CapabilityUtils
 import com.owncloud.android.utils.theme.ViewThemeUtils
 import kotlinx.coroutines.Dispatchers
 import kotlinx.coroutines.ensureActive
@@ -73,6 +76,7 @@ class AutoUploadWorker(
     private val fileUploadEventBroadcaster = FileUploadEventBroadcaster(localBroadcastManager)
     private lateinit var syncedFolder: SyncedFolder
     private val notificationManager = AutoUploadNotificationManager(context, viewThemeUtils, NOTIFICATION_ID)
+    private val fileUploadHelper = FileUploadHelper.instance()
 
     @Suppress("ReturnCount")
     override suspend fun doWork(): Result {
@@ -243,6 +247,7 @@ class AutoUploadWorker(
         val ocAccount = OwnCloudAccount(user.toPlatformAccount(), context)
         val client = OwnCloudClientManagerFactory.getDefaultSingleton()
             .getClientFor(ocAccount, context)
+        val capability = CapabilityUtils.getCapability(user, context)
 
         updateNotification()
 
@@ -265,7 +270,7 @@ class AutoUploadWorker(
                 val remotePath = syncFolderHelper.getAutoUploadRemotePath(syncedFolder, file)
 
                 try {
-                    val entityResult = getEntityResult(user, localPath, remotePath)
+                    val entityResult = getEntityResult(user, localPath, remotePath, capability)
                     if (entityResult !is AutoUploadEntityResult.Success) {
                         repository.markFileAsHandled(localPath, syncedFolder)
                         Log_OC.d(TAG, "marked file as handled: $localPath")
@@ -358,12 +363,17 @@ class AutoUploadWorker(
     }
 
     @Suppress("ReturnCount")
-    private fun getEntityResult(user: User, localPath: String, remotePath: String): AutoUploadEntityResult {
+    private fun getEntityResult(
+        user: User,
+        localPath: String,
+        remotePath: String,
+        capability: OCCapability
+    ): AutoUploadEntityResult {
         val (needsCharging, needsWifi, uploadAction) = getUploadSettings(syncedFolder)
         Log_OC.d(TAG, "creating oc upload for ${user.accountName}")
 
         // Get existing upload or create new one
-        val uploadEntity = uploadsStorageManager.uploadDao.getUploadByAccountAndPaths(
+        val uploadEntity = fileUploadHelper.getUploadByPaths(
             localPath = localPath,
             remotePath = remotePath,
             accountName = user.accountName
@@ -379,7 +389,7 @@ class AutoUploadWorker(
         }
 
         val upload = try {
-            uploadEntity?.toOCUpload(null) ?: OCUpload(localPath, remotePath, user.accountName)
+            uploadEntity?.toOCUpload(capability) ?: OCUpload(localPath, remotePath, user.accountName)
         } catch (_: IllegalArgumentException) {
             Log_OC.e(TAG, "cannot construct oc upload")
             return AutoUploadEntityResult.CreationError

app/src/main/java/com/nextcloud/client/jobs/upload/FileUploadHelper.kt

@@ -23,6 +23,7 @@ import com.nextcloud.client.jobs.upload.FileUploadWorker.Companion.currentUpload
 import com.nextcloud.client.network.Connectivity
 import com.nextcloud.client.network.ConnectivityService
 import com.nextcloud.client.notifications.AppWideNotificationManager
+import com.nextcloud.utils.extensions.checkWCFRestrictions
 import com.nextcloud.utils.extensions.getUploadIds
 import com.owncloud.android.MainApp
 import com.owncloud.android.R
@@ -281,12 +282,19 @@ class FileUploadHelper {
 
     @Suppress("ReturnCount")
     fun getUploadByPaths(accountName: String, localPath: String, remotePath: String): UploadEntity? {
-        uploadsStorageManager.uploadDao.getUploadByAccountAndPaths(
+        val entity = uploadsStorageManager.uploadDao.getUploadByAccountAndPaths(
             accountName,
             localPath,
             remotePath
         )?.let { return it }
 
+        val capability = fileStorageManager.getCapability(accountManager.user)
+        if (!capability.checkWCFRestrictions()) {
+            // The filesystem should treat files as case-sensitive. For example, "a.TXT" and "a.txt"
+            // are allowed to exist in the same directory as two distinct files.
+            return entity
+        }
+
         val dotIndex = remotePath.lastIndexOf('.')
         if (dotIndex == -1) return null
 

app/src/main/java/com/owncloud/android/ui/adapter/UploadListAdapter.java

@@ -837,7 +837,11 @@ public final void loadUploadItemsFromDb(Runnable onCompleted) {
                 final int index = i;
                 Section sec = sections.get(index);
 
-                uploadHelper.getUploadsByStatus(accountName, sec.status(), sec.collisionPolicy(), uploads -> {
+                uploadHelper.getUploadsByStatus(accountName,
+                                                sec.status(),
+                                                parentActivity.getCapabilities(),
+                                                sec.collisionPolicy(),
+                                                uploads -> {
                     for (OCUpload upload : uploads) {
                         upload.setDataFixed(uploadHelper);
                     }