simplify sync file calls

Signed-off-by: alperozturk96 <alper_ozturk@proton.me>

Author: alperozturk96

app/src/main/java/com/owncloud/android/ui/activity/FileDisplayActivity.kt

@@ -2212,7 +2212,7 @@ class FileDisplayActivity :
 
                 // download new version, only if file was previously download
                 showSyncLoadingDialog(file.isFolder)
-                fileOperationsHelper.syncFileOrFolder(file, false)
+                fileOperationsHelper.syncFileOrFolder(file)
             }
 
             val parent = file?.let { storageManager.getFileById(it.parentId) }

app/src/main/java/com/owncloud/android/ui/fragment/FileDetailFragment.java

@@ -462,12 +462,11 @@ private void optionsItemSelected(@IdRes final int itemId) {
             dialog.show(getFragmentManager(), FTAG_RENAME_FILE);
         } else if (itemId == R.id.action_cancel_sync) {
             ((FileDisplayActivity) containerActivity).cancelTransference(getFile());
-        } else if (itemId == R.id.action_download_file || itemId == R.id.action_sync_file || itemId == R.id.action_sync_all_files) {
+        } else if (itemId == R.id.action_download_file || itemId == R.id.action_sync_file) {
             if (containerActivity instanceof FileActivity activity) {
                 activity.showSyncLoadingDialog(getFile().isFolder());
             }
-            boolean syncAll = (itemId == R.id.action_sync_all_files);
-            containerActivity.getFileOperationsHelper().syncFileOrFolder(getFile(), syncAll);
+            containerActivity.getFileOperationsHelper().syncFileOrFolder(getFile());
         } else if (itemId == R.id.action_export_file) {
             ArrayList<OCFile> list = new ArrayList<>();
             list.add(getFile());

app/src/main/java/com/owncloud/android/ui/fragment/OCFileListFragment.java

@@ -2233,7 +2233,7 @@ private boolean isSearchEventSet(SearchEvent event) {
 
     private void syncFolderIncludingAllNestedFiles(OCFile folder) {
         if (FileStorageUtils.checkIfEnoughSpace(folder)) {
-            mContainerActivity.getFileOperationsHelper().syncFileOrFolder(folder, false, true);
+            mContainerActivity.getFileOperationsHelper().syncFolderIncludingNestedFiles(folder);
         } else {
             SyncFileNotEnoughSpaceDialogFragment
                 .newInstance(folder, FileOperationsHelper.getAvailableSpaceOnDevice())

app/src/main/java/com/owncloud/android/ui/helpers/FileOperationsHelper.java

@@ -877,8 +877,12 @@ public void syncFileOrFolder(OCFile file, boolean postDialogEvent, boolean syncA
         }
     }
 
-    public void syncFileOrFolder(OCFile file, boolean syncAll) {
-        syncFileOrFolder(file, false, syncAll);
+    public void syncFileOrFolder(OCFile file) {
+        syncFileOrFolder(file, false, false);
+    }
+
+    public void syncFolderIncludingNestedFiles(OCFile file) {
+        syncFileOrFolder(file, false, true);
     }
 
     private void startSyncFolderIntent(ServerFileInterface file, boolean syncAll) {
@@ -887,6 +891,7 @@ private void startSyncFolderIntent(ServerFileInterface file, boolean syncAll) {
         intent.putExtra(OperationsService.EXTRA_ACCOUNT, fileActivity.getAccount());
         intent.putExtra(OperationsService.EXTRA_REMOTE_PATH, file.getRemotePath());
         intent.putExtra(OperationsService.EXTRA_SYNC_ALL, syncAll);
+
         fileActivity.startService(intent);
     }
 

app/src/main/java/com/owncloud/android/ui/preview/PreviewImageFragment.kt

@@ -415,7 +415,7 @@ class PreviewImageFragment :
                 val activity = containerActivity as FileActivity
                 activity.showSyncLoadingDialog(file.isFolder)
             }
-            containerActivity.fileOperationsHelper.syncFileOrFolder(file, false)
+            containerActivity.fileOperationsHelper.syncFileOrFolder(file)
         } else if (itemId == R.id.action_cancel_sync) {
             containerActivity.fileOperationsHelper.cancelTransference(file)
         } else if (itemId == R.id.action_set_as_wallpaper) {

app/src/main/java/com/owncloud/android/ui/preview/PreviewMediaActivity.kt

@@ -584,7 +584,7 @@ class PreviewMediaActivity :
 
             R.id.action_sync_file -> {
                 showSyncLoadingDialog(file?.isFolder == true)
-                fileOperationsHelper.syncFileOrFolder(file, false)
+                fileOperationsHelper.syncFileOrFolder(file)
             }
 
             R.id.action_cancel_sync -> {

app/src/main/java/com/owncloud/android/ui/preview/PreviewMediaFragment.kt

@@ -393,7 +393,7 @@ class PreviewMediaFragment :
 
             R.id.action_sync_file -> {
                 getTypedActivity(FileActivity::class.java)?.showSyncLoadingDialog(file.isFolder)
-                containerActivity.fileOperationsHelper.syncFileOrFolder(file, false)
+                containerActivity.fileOperationsHelper.syncFileOrFolder(file)
             }
 
             R.id.action_cancel_sync -> {

app/src/main/java/com/owncloud/android/ui/preview/PreviewTextFileFragment.java

@@ -306,7 +306,7 @@ private void onFileActionChosen(final int itemId) {
             if (containerActivity instanceof FileActivity activity) {
                 activity.showSyncLoadingDialog(getFile().isFolder());
             }
-            containerActivity.getFileOperationsHelper().syncFileOrFolder(getFile(), false);
+            containerActivity.getFileOperationsHelper().syncFileOrFolder(getFile());
         } else if(itemId == R.id.action_cancel_sync){
             containerActivity.getFileOperationsHelper().cancelTransference(getFile());
         } else if (itemId == R.id.action_edit) {