fix logic and add TODOs

Signed-off-by: alperozturk <alper_ozturk@proton.me>

Author: alperozturk96

app/src/main/java/com/nextcloud/utils/extensions/ViewExtensions.kt

@@ -7,6 +7,8 @@
  */
 package com.nextcloud.utils.extensions
 
+import android.animation.Animator
+import android.animation.AnimatorListenerAdapter
 import android.content.Context
 import android.graphics.Outline
 import android.util.TypedValue
@@ -19,6 +21,30 @@ fun View?.setVisibleIf(condition: Boolean) {
     visibility = if (condition) View.VISIBLE else View.GONE
 }
 
+fun View?.setVisibilityWithAnimation(condition: Boolean, duration: Long = 200L) {
+    this ?: return
+
+    if (condition) {
+        this.apply {
+            alpha = 0f
+            visibility = View.VISIBLE
+            animate()
+                .alpha(1f)
+                .setDuration(duration)
+                .setListener(null)
+        }
+    } else {
+        animate()
+            .alpha(0f)
+            .setDuration(duration)
+            .setListener(object : AnimatorListenerAdapter() {
+                override fun onAnimationEnd(animation: Animator) {
+                    visibility = View.GONE
+                }
+            })
+    }
+}
+
 fun View?.makeRounded(context: Context, cornerRadius: Float) {
     this?.let {
         it.apply {

app/src/main/java/com/owncloud/android/ui/fragment/FileDetailsSharingProcessFragment.kt

@@ -21,6 +21,7 @@ import androidx.fragment.app.Fragment
 import com.nextcloud.client.di.Injectable
 import com.nextcloud.utils.extensions.getParcelableArgument
 import com.nextcloud.utils.extensions.getSerializableArgument
+import com.nextcloud.utils.extensions.setVisibilityWithAnimation
 import com.nextcloud.utils.extensions.setVisibleIf
 import com.owncloud.android.R
 import com.owncloud.android.databinding.FileDetailsSharingProcessFragmentBinding
@@ -135,6 +136,7 @@ class FileDetailsSharingProcessFragment :
     private var isReShareShown: Boolean = true // show or hide reShare option
     private var isExpDateShown: Boolean = true // show or hide expiry date option
     private var isSecureShare: Boolean = false
+    private var showCustomPermissions = true
 
     private lateinit var capabilities: OCCapability
 
@@ -190,20 +192,20 @@ class FileDetailsSharingProcessFragment :
         }
         implementClickEvents()
         setCheckboxStates()
+        setCustomPermissionCheckboxesVisibilities()
         themeView()
     }
 
     private fun themeView() {
         viewThemeUtils.platform.run {
             binding.run {
                 colorTextView(shareProcessEditShareLink)
-                colorTextView(shareProcessAdvancePermissionTitle)
+                colorTextView(shareCustomPermissionsText)
 
                 themeRadioButton(shareProcessPermissionReadOnly)
                 themeRadioButton(shareProcessPermissionUploadEditing)
                 themeRadioButton(shareProcessPermissionFileDrop)
 
-                themeCheckbox(shareCustomCheckbox)
                 themeCheckbox(shareReadCheckbox)
                 themeCheckbox(shareCreateCheckbox)
                 themeCheckbox(shareEditCheckbox)
@@ -259,7 +261,7 @@ class FileDetailsSharingProcessFragment :
         }
 
         if (isSecureShare) {
-            binding.shareProcessAdvancePermissionTitle.visibility = View.GONE
+            binding.shareCustomPermissionsText.visibility = View.GONE
         }
 
         // show or hide expiry date
@@ -472,12 +474,12 @@ class FileDetailsSharingProcessFragment :
             shareProcessSelectExpDate.setOnClickListener {
                 showExpirationDateDialog()
             }
-            shareCustomCheckbox.setOnCheckedChangeListener {  _, isChecked ->
-                shareReadCheckbox.isChecked = isChecked
-                shareCreateCheckbox.isChecked = isChecked
-                shareEditCheckbox.isChecked = isChecked
-                shareProcessAllowResharingCheckbox.isChecked = isChecked
-                shareDeleteCheckbox.isChecked = isChecked
+
+            shareCustomPermissionsText.setOnClickListener {
+                showCustomPermissions = !showCustomPermissions
+                val newIcon = if (showCustomPermissions) R.drawable.ic_arrow_up else R.drawable.ic_arrow_down
+                shareCustomPermissionsText.setCompoundDrawablesWithIntrinsicBounds(0, 0, newIcon, 0)
+                setCustomPermissionCheckboxesVisibilities()
             }
 
             shareReadCheckbox.setOnCheckedChangeListener { _, isChecked ->
@@ -502,13 +504,12 @@ class FileDetailsSharingProcessFragment :
         }
     }
 
+    // TODO: check share.permission
     private fun setUserPermission(isChecked: Boolean, permissionFlag: Int) {
-        share?.let {
-            it.permissions = if (isChecked) {
-                it.permissions or permissionFlag
-            } else {
-                it.permissions and permissionFlag.inv()
-            }
+        permission = if (isChecked) {
+            permission or permissionFlag
+        } else {
+            permission and permissionFlag.inv()
         }
     }
 
@@ -519,6 +520,18 @@ class FileDetailsSharingProcessFragment :
             shareEditCheckbox.isChecked = (permission and OCShare.UPDATE_PERMISSION_FLAG) != 0
             shareProcessAllowResharingCheckbox.isChecked = (permission and OCShare.SHARE_PERMISSION_FLAG) != 0
             shareDeleteCheckbox.isChecked = (permission and OCShare.DELETE_PERMISSION_FLAG) != 0
+
+            setCustomPermissionCheckboxesVisibilities()
+        }
+    }
+
+    private fun setCustomPermissionCheckboxesVisibilities() {
+        binding.run {
+            shareReadCheckbox.setVisibilityWithAnimation(showCustomPermissions)
+            shareCreateCheckbox.setVisibilityWithAnimation(showCustomPermissions)
+            shareEditCheckbox.setVisibilityWithAnimation(showCustomPermissions)
+            shareProcessAllowResharingCheckbox.setVisibilityWithAnimation(showCustomPermissions)
+            shareDeleteCheckbox.setVisibilityWithAnimation(showCustomPermissions)
         }
     }
 
@@ -642,6 +655,7 @@ class FileDetailsSharingProcessFragment :
     /**
      *  get the permissions on the basis of selection
      */
+    // TODO: Check logic it should match with new checkboxes action
     private fun getSelectedPermission() = when {
         binding.shareProcessAllowResharingCheckbox.isChecked -> getReSharePermission()
         binding.shareProcessPermissionReadOnly.isChecked -> OCShare.READ_PERMISSION_FLAG

app/src/main/res/drawable/ic_arrow_down.xml

@@ -0,0 +1,5 @@
+<vector xmlns:android="http://schemas.android.com/apk/res/android" android:height="24dp" android:tint="#FFFFFF" android:viewportHeight="24" android:viewportWidth="24" android:width="24dp">
+      
+    <path android:fillColor="@android:color/white" android:pathData="M20,12l-1.41,-1.41L13,16.17V4h-2v12.17l-5.58,-5.59L4,12l8,8 8,-8z"/>
+    
+</vector>

app/src/main/res/layout/file_details_sharing_process_fragment.xml

@@ -68,28 +68,20 @@
             </RadioGroup>
 
             <androidx.appcompat.widget.AppCompatTextView
-                android:id="@+id/share_process_advance_permission_title"
+                android:id="@+id/share_custom_permissions_text"
                 android:layout_width="match_parent"
                 android:layout_height="wrap_content"
                 android:layout_marginTop="@dimen/standard_margin"
-                android:text="@string/advanced_settings"
+                android:text="@string/share_custom_permission"
+                android:drawableEnd="@drawable/ic_arrow_up"
                 android:textColor="@color/primary"
+                android:drawableTint="@color/primary"
                 android:textStyle="bold"/>
 
-            <com.google.android.material.checkbox.MaterialCheckBox
-                android:id="@+id/share_custom_checkbox"
-                android:layout_width="match_parent"
-                android:layout_height="wrap_content"
-                android:minHeight="@dimen/minimum_size_for_touchable_area"
-                android:text="@string/share_custom_permission"
-                android:visibility="visible"
-                tools:visibility="visible" />
-
             <com.google.android.material.checkbox.MaterialCheckBox
                 android:id="@+id/share_read_checkbox"
                 android:layout_width="match_parent"
                 android:layout_height="wrap_content"
-                android:layout_marginStart="@dimen/standard_margin"
                 android:minHeight="@dimen/minimum_size_for_touchable_area"
                 android:text="@string/share_read_permission"
                 android:visibility="gone"
@@ -99,7 +91,6 @@
                 android:id="@+id/share_create_checkbox"
                 android:layout_width="match_parent"
                 android:layout_height="wrap_content"
-                android:layout_marginStart="@dimen/standard_margin"
                 android:minHeight="@dimen/minimum_size_for_touchable_area"
                 android:text="@string/share_create_permission"
                 android:visibility="gone"
@@ -109,7 +100,6 @@
                 android:id="@+id/share_edit_checkbox"
                 android:layout_width="match_parent"
                 android:layout_height="wrap_content"
-                android:layout_marginStart="@dimen/standard_margin"
                 android:minHeight="@dimen/minimum_size_for_touchable_area"
                 android:text="@string/share_edit_permission"
                 android:visibility="gone"
@@ -119,7 +109,6 @@
                 android:id="@+id/share_process_allow_resharing_checkbox"
                 android:layout_width="match_parent"
                 android:layout_height="wrap_content"
-                android:layout_marginStart="@dimen/standard_margin"
                 android:minHeight="@dimen/minimum_size_for_touchable_area"
                 android:text="@string/share_re_share_permission"
                 android:visibility="gone"
@@ -129,7 +118,6 @@
                 android:id="@+id/share_delete_checkbox"
                 android:layout_width="match_parent"
                 android:layout_height="wrap_content"
-                android:layout_marginStart="@dimen/standard_margin"
                 android:minHeight="@dimen/minimum_size_for_touchable_area"
                 android:text="@string/share_delete_permission"
                 android:visibility="gone"