Skip to content

Commit 63d18bc

Browse files
committed
Fix -> video click event, overflow menu item hide and theming add menu
Signed-off-by: Surinder Kumar <surinder.kumar@t-systems.com>
1 parent a75ee4f commit 63d18bc

7 files changed

Lines changed: 34 additions & 7 deletions

File tree

app/src/main/java/com/owncloud/android/ui/activity/AlbumsPickerActivity.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
/*
22
* Nextcloud - Android Client
33
*
4-
* SPDX-FileCopyrightText: 2025 Your Name <your@email.com>
4+
* SPDX-FileCopyrightText: 2025 TSI-mc <surinder.kumar@t-systems.com>
55
* SPDX-License-Identifier: AGPL-3.0-or-later
66
*/
77

app/src/main/java/com/owncloud/android/ui/adapter/albums/AlbumGridItemViewHolder.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
/*
22
* Nextcloud - Android Client
33
*
4-
* SPDX-FileCopyrightText: 2025 Your Name <your@email.com>
4+
* SPDX-FileCopyrightText: 2025 TSI-mc <surinder.kumar@t-systems.com>
55
* SPDX-License-Identifier: AGPL-3.0-or-later
66
*/
77

app/src/main/java/com/owncloud/android/ui/adapter/albums/AlbumListItemViewHolder.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
/*
22
* Nextcloud - Android Client
33
*
4-
* SPDX-FileCopyrightText: 2025 Your Name <your@email.com>
4+
* SPDX-FileCopyrightText: 2025 TSI-mc <surinder.kumar@t-systems.com>
55
* SPDX-License-Identifier: AGPL-3.0-or-later
66
*/
77

app/src/main/java/com/owncloud/android/ui/fragment/ExtendedListFragment.kt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
/*
22
* Nextcloud - Android Client
33
*
4+
* SPDX-FileCopyrightText: 2025 TSI-mc <surinder.kumar@t-systems.com>
45
* SPDX-FileCopyrightText: 2025 Alper Ozturk <alper.ozturk@nextcloud.com>
56
* SPDX-FileCopyrightText: 2022 Álvaro Brey <alvaro.brey@nextcloud.com>
67
* SPDX-FileCopyrightText: 2018-2021 Tobias Kaminsky <tobias@kaminsky.me>

app/src/main/java/com/owncloud/android/ui/fragment/OCFileListFragment.java

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -81,6 +81,7 @@
8181
import com.owncloud.android.lib.resources.status.E2EVersion;
8282
import com.owncloud.android.lib.resources.status.OCCapability;
8383
import com.owncloud.android.lib.resources.status.Type;
84+
import com.owncloud.android.ui.activity.AlbumsPickerActivity;
8485
import com.owncloud.android.ui.activity.DrawerActivity;
8586
import com.owncloud.android.ui.activity.FileActivity;
8687
import com.owncloud.android.ui.activity.FileDisplayActivity;
@@ -818,7 +819,13 @@ public boolean onCreateActionMode(ActionMode mode, Menu menu) {
818819

819820
if (OCFileListFragment.this instanceof GalleryFragment) {
820821
final MenuItem addAlbumItem = menu.findItem(R.id.add_to_album);
822+
// show add to album button for gallery to add media to Album
821823
addAlbumItem.setVisible(true);
824+
825+
// hide the 3 dot menu icon while picking media for Albums
826+
if (requireActivity() instanceof AlbumsPickerActivity) {
827+
item.setVisible(false);
828+
}
822829
}
823830

824831
getCommonAdapter().setMultiSelect(true);

app/src/main/java/com/owncloud/android/ui/fragment/albums/AlbumItemsFragment.kt

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -61,16 +61,16 @@ import com.owncloud.android.lib.resources.albums.ReadAlbumItemsRemoteOperation
6161
import com.owncloud.android.lib.resources.albums.RemoveAlbumFileRemoteOperation
6262
import com.owncloud.android.lib.resources.albums.ToggleAlbumFavoriteRemoteOperation
6363
import com.owncloud.android.ui.activity.AlbumsPickerActivity
64+
import com.owncloud.android.ui.activity.AlbumsPickerActivity.Companion.intentForPickingMediaFiles
6465
import com.owncloud.android.ui.activity.FileActivity
6566
import com.owncloud.android.ui.activity.FileDisplayActivity
6667
import com.owncloud.android.ui.adapter.GalleryAdapter
6768
import com.owncloud.android.ui.dialog.CreateAlbumDialogFragment
6869
import com.owncloud.android.ui.events.FavoriteEvent
6970
import com.owncloud.android.ui.fragment.FileFragment
70-
import com.owncloud.android.ui.activity.AlbumsPickerActivity.Companion.intentForPickingMediaFiles
7171
import com.owncloud.android.ui.interfaces.OCFileListFragmentInterface
7272
import com.owncloud.android.ui.preview.PreviewImageFragment
73-
import com.owncloud.android.ui.preview.PreviewMediaActivity
73+
import com.owncloud.android.ui.preview.PreviewMediaActivity.Companion.canBePreviewed
7474
import com.owncloud.android.utils.DisplayUtils
7575
import com.owncloud.android.utils.ErrorMessageAdapter
7676
import com.owncloud.android.utils.FileStorageUtils
@@ -484,13 +484,17 @@ class AlbumItemsFragment : Fragment(), OCFileListFragmentInterface, Injectable {
484484
if (PreviewImageFragment.canBePreviewed(file)) {
485485
(mContainerActivity as FileDisplayActivity).startImagePreview(file, !file.isDown)
486486
} else if (file.isDown) {
487-
if (PreviewMediaActivity.canBePreviewed(file)) {
487+
if (canBePreviewed(file)) {
488488
(mContainerActivity as FileDisplayActivity).startMediaPreview(file, 0, true, true, false, true)
489489
} else {
490490
mContainerActivity?.getFileOperationsHelper()?.openFile(file)
491491
}
492492
} else {
493-
Log_OC.d(TAG, "Couldn't handle item click")
493+
if (canBePreviewed(file) && !file.isEncrypted) {
494+
(mContainerActivity as FileDisplayActivity).startMediaPreview(file, 0, true, true, true, true)
495+
} else {
496+
Log_OC.d(TAG, "Couldn't handle item click")
497+
}
494498
}
495499
}
496500
}

app/src/main/java/com/owncloud/android/ui/fragment/albums/AlbumsFragment.kt

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,13 +12,17 @@ import android.content.Context
1212
import android.content.Intent
1313
import android.content.res.Configuration
1414
import android.os.Bundle
15+
import android.text.Spannable
16+
import android.text.SpannableString
17+
import android.text.style.ForegroundColorSpan
1518
import android.view.LayoutInflater
1619
import android.view.Menu
1720
import android.view.MenuInflater
1821
import android.view.MenuItem
1922
import android.view.View
2023
import android.view.ViewGroup
2124
import androidx.annotation.VisibleForTesting
25+
import androidx.core.content.ContextCompat
2226
import androidx.core.content.res.ResourcesCompat
2327
import androidx.core.view.MenuHost
2428
import androidx.core.view.MenuProvider
@@ -137,6 +141,17 @@ class AlbumsFragment : Fragment(), AlbumFragmentInterface, Injectable {
137141
override fun onCreateMenu(menu: Menu, menuInflater: MenuInflater) {
138142
menu.clear() // important: clears any existing activity menu
139143
menuInflater.inflate(R.menu.fragment_create_album, menu)
144+
145+
val addItem = menu.findItem(R.id.action_create_new_album)
146+
val coloredTitle = SpannableString(addItem.title).apply {
147+
setSpan(
148+
ForegroundColorSpan(ContextCompat.getColor(requireContext(), R.color.primary)),
149+
0,
150+
length,
151+
Spannable.SPAN_INCLUSIVE_INCLUSIVE
152+
)
153+
}
154+
addItem.title = coloredTitle
140155
}
141156

142157
override fun onMenuItemSelected(menuItem: MenuItem): Boolean {

0 commit comments

Comments
 (0)