Skip to content

Commit 6eae614

Browse files
committed
fix radio button setOnCheckedChangeListener logic
Signed-off-by: alperozturk <alper_ozturk@proton.me>
1 parent 8a673cb commit 6eae614

1 file changed

Lines changed: 6 additions & 15 deletions

File tree

app/src/main/java/com/owncloud/android/ui/fragment/FileDetailsSharingProcessFragment.kt

Lines changed: 6 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -175,7 +175,7 @@ class FileDetailsSharingProcessFragment :
175175

176176
fileActivity = activity as FileActivity?
177177
capabilities = CapabilityUtils.getCapability(context)
178-
setInitialPermission()
178+
permission = getMaximumPermission()
179179

180180
requireNotNull(fileActivity) { "FileActivity may not be null" }
181181
}
@@ -201,14 +201,12 @@ class FileDetailsSharingProcessFragment :
201201

202202
private fun isFolder(): Boolean = file?.isFolder == true || share?.isFolder == true
203203

204-
private fun setInitialPermission() {
205-
val permissionFlag = if (isFolder()) {
204+
private fun getMaximumPermission(): Int {
205+
return if (isFolder()) {
206206
OCShare.MAXIMUM_PERMISSIONS_FOR_FOLDER
207207
} else {
208208
OCShare.MAXIMUM_PERMISSIONS_FOR_FILE
209209
}
210-
211-
permission = permissionFlag
212210
}
213211

214212
private fun themeView() {
@@ -507,23 +505,16 @@ class FileDetailsSharingProcessFragment :
507505
when (optionId) {
508506
R.id.view_only_radio_button -> {
509507
customPermissionLayout.visibility = View.GONE
510-
togglePermission(OCShare.READ_PERMISSION_FLAG)
508+
permission = OCShare.READ_PERMISSION_FLAG
511509
}
512510

513511
R.id.editing_radio_button -> {
514512
customPermissionLayout.visibility = View.GONE
515-
516-
val permissionFlag = if (isFolder()) {
517-
OCShare.MAXIMUM_PERMISSIONS_FOR_FOLDER
518-
} else {
519-
OCShare.MAXIMUM_PERMISSIONS_FOR_FILE
520-
}
521-
522-
togglePermission(permissionFlag)
513+
permission = getMaximumPermission()
523514
}
524515

525516
R.id.file_drop_radio_button -> {
526-
togglePermission(OCShare.CREATE_PERMISSION_FLAG)
517+
permission = OCShare.CREATE_PERMISSION_FLAG
527518
}
528519

529520
R.id.custom_permission_radio_button -> {

0 commit comments

Comments
 (0)