remove unnecessary logic

Signed-off-by: alperozturk96 <alper_ozturk@proton.me>

Author: alperozturk96

app/src/main/java/com/owncloud/android/ui/activity/ExtendedSettingsActivity.kt

@@ -15,20 +15,10 @@ import com.owncloud.android.ui.model.ExtendedSettingsActivityDialog
 
 class ExtendedSettingsActivity : AppCompatActivity() {
 
-    private var dialogShown = false
-
     @Suppress("ReturnCount")
     override fun onCreate(savedInstanceState: Bundle?) {
         super.onCreate(savedInstanceState)
 
-        if (savedInstanceState != null) {
-            dialogShown = savedInstanceState.getBoolean(KEY_DIALOG_SHOWN, false)
-        }
-
-        if (dialogShown) {
-            return
-        }
-
         val dialogKey = intent.getStringExtra(EXTRA_DIALOG_TYPE) ?: run {
             finish()
             return
@@ -41,18 +31,11 @@ class ExtendedSettingsActivity : AppCompatActivity() {
 
         val dismissable = intent.getBooleanExtra(EXTRA_DISMISSABLE, true)
         dialogType.showDialog(this, dismissable)
-        dialogShown = true
-    }
-
-    override fun onSaveInstanceState(outState: Bundle) {
-        super.onSaveInstanceState(outState)
-        outState.putBoolean(KEY_DIALOG_SHOWN, dialogShown)
     }
 
     companion object {
         private const val EXTRA_DISMISSABLE = "dismissable"
         private const val EXTRA_DIALOG_TYPE = "dialog_type"
-        private const val KEY_DIALOG_SHOWN = "dialog_shown"
 
         @JvmOverloads
         fun createIntent(

app/src/main/java/com/owncloud/android/ui/dialog/AppPassCodeDialog.kt

@@ -39,6 +39,8 @@ class AppPassCodeDialog :
 
     private lateinit var binding: DialogAppPasscodeBinding
 
+    private var currentSelection = SettingsActivity.LOCK_NONE
+
     override fun onStart() {
         super.onStart()
         val alertDialog = dialog as AlertDialog
@@ -55,7 +57,8 @@ class AppPassCodeDialog :
     override fun onCreateDialog(savedInstanceState: Bundle?): Dialog {
         binding = DialogAppPasscodeBinding.inflate(layoutInflater)
 
-        val currentLock = preferences.lockPreference ?: SettingsActivity.LOCK_NONE
+        currentSelection = preferences.lockPreference ?: SettingsActivity.LOCK_NONE
+
         val passCodeEnabled = resources.getBoolean(R.bool.passcode_enabled)
         val deviceCredentialsEnabled = resources.getBoolean(R.bool.device_credentials_enabled)
         val enforceProtection = MDMConfig.enforceProtection(requireContext())
@@ -67,7 +70,7 @@ class AppPassCodeDialog :
         binding.lockNone.setVisibleIf(!enforceProtection)
 
         setupTheme()
-        setCurrentSelection(currentLock)
+        setCurrentSelection()
         setupListener()
 
         val builder = MaterialAlertDialogBuilder(requireContext())
@@ -99,10 +102,10 @@ class AppPassCodeDialog :
         }
     }
 
-    private fun setCurrentSelection(currentLock: String) {
+    private fun setCurrentSelection() {
         val radioGroup = binding.lockRadioGroup
 
-        when (currentLock) {
+        when (currentSelection) {
             SettingsActivity.LOCK_PASSCODE -> radioGroup.check(R.id.lock_passcode)
             SettingsActivity.LOCK_DEVICE_CREDENTIALS -> radioGroup.check(R.id.lock_device_credentials)
             SettingsActivity.LOCK_NONE -> radioGroup.check(R.id.lock_none)
@@ -122,10 +125,8 @@ class AppPassCodeDialog :
         }
     }
 
-    private var currentSelection: String? = null
-
     private fun applySelection() {
-        val selectedLock = currentSelection ?: return
+        val selectedLock = currentSelection
 
         setFragmentResult(
             ExtendedSettingsActivityDialog.AppPasscode.key,