remove unnecessary allow reshare checkbox

Signed-off-by: alperozturk <alper_ozturk@proton.me>

Author: alperozturk96

app/src/main/java/com/owncloud/android/ui/fragment/FileDetailsSharingProcessFragment.kt

@@ -218,8 +218,6 @@ class FileDetailsSharingProcessFragment :
                 themeCheckbox(shareEditCheckbox)
                 themeCheckbox(shareCheckbox)
                 themeCheckbox(shareDeleteCheckbox)
-
-                themeCheckbox(shareProcessAllowResharingCheckbox)
             }
         }
 
@@ -269,10 +267,6 @@ class FileDetailsSharingProcessFragment :
             setupUpdateUI()
         }
 
-        if (isSecureShare) {
-            binding.shareProcessAdvancePermissionTitle.visibility = View.GONE
-        }
-
         // show or hide expiry date
         binding.shareProcessSetExpDateSwitch.setVisibleIf(isExpDateShown && !isSecureShare)
         shareProcessStep = SCREEN_TYPE_PERMISSION
@@ -370,25 +364,21 @@ class FileDetailsSharingProcessFragment :
         binding.shareProcessChangeNameSwitch.visibility = View.GONE
         binding.shareProcessChangeNameContainer.visibility = View.GONE
         binding.shareProcessHideDownloadCheckbox.visibility = View.GONE
-        if (isSecureShare) {
-            binding.shareProcessAllowResharingCheckbox.visibility = View.GONE
-        } else {
-            binding.shareProcessAllowResharingCheckbox.visibility = View.VISIBLE
-        }
+        binding.shareCheckbox.setVisibleIf(!isSecureShare)
         binding.shareProcessSetPasswordSwitch.visibility = View.GONE
 
         if (share != null) {
             if (!isReShareShown) {
-                binding.shareProcessAllowResharingCheckbox.visibility = View.GONE
+                binding.shareCheckbox.visibility = View.GONE
             }
-            binding.shareProcessAllowResharingCheckbox.isChecked = SharingMenuHelper.canReshare(share)
+            binding.shareCheckbox.isChecked = SharingMenuHelper.canReshare(share)
         }
     }
 
     private fun updateViewForExternalAndLinkShare() {
         binding.run {
             shareProcessHideDownloadCheckbox.visibility = View.VISIBLE
-            shareProcessAllowResharingCheckbox.visibility = View.GONE
+            shareCheckbox.visibility = View.GONE
             shareProcessSetPasswordSwitch.visibility = View.VISIBLE
 
             if (share != null) {
@@ -444,7 +434,7 @@ class FileDetailsSharingProcessFragment :
             fileDropRadioButton.visibility = View.VISIBLE
             if (isSecureShare) {
                 fileDropRadioButton.visibility = View.GONE
-                shareProcessAllowResharingCheckbox.visibility = View.GONE
+                shareCheckbox.visibility = View.GONE
                 shareProcessSetExpDateSwitch.visibility = View.GONE
             }
         }
@@ -577,10 +567,6 @@ class FileDetailsSharingProcessFragment :
                 togglePermission(OCShare.UPDATE_PERMISSION_FLAG)
             }
 
-            shareProcessAllowResharingCheckbox.setOnCheckedChangeListener { _, isChecked ->
-                permission = sharePermissionManager.getReSharePermission()
-            }
-
             shareCheckbox.setOnCheckedChangeListener { _, isChecked ->
                 togglePermission(OCShare.SHARE_PERMISSION_FLAG)
             }

app/src/main/java/com/owncloud/android/ui/fragment/util/SharePermissionManager.kt

@@ -9,7 +9,6 @@ package com.owncloud.android.ui.fragment.util
 
 import com.owncloud.android.lib.common.utils.Log_OC
 import com.owncloud.android.lib.resources.shares.OCShare
-import com.owncloud.android.lib.resources.shares.SharePermissionsBuilder
 import com.owncloud.android.ui.fragment.FileDetailsSharingProcessFragment.Companion.TAG
 
 class SharePermissionManager {
@@ -78,12 +77,6 @@ class SharePermissionManager {
         }
     }
 
-    fun getReSharePermission(): Int {
-        return SharePermissionsBuilder().apply {
-            setSharePermission(true)
-        }.build()
-    }
-
     fun getMaximumPermission(isFolder: Boolean): Int {
         return if (isFolder) {
             OCShare.MAXIMUM_PERMISSIONS_FOR_FOLDER

app/src/main/res/layout/file_details_sharing_process_fragment.xml

@@ -74,24 +74,6 @@
 
             </RadioGroup>
 
-            <androidx.appcompat.widget.AppCompatTextView
-                android:id="@+id/share_process_advance_permission_title"
-                android:layout_width="match_parent"
-                android:layout_height="wrap_content"
-                android:layout_marginTop="@dimen/standard_margin"
-                android:text="@string/advanced_settings"
-                android:textColor="@color/primary"
-                android:textStyle="bold"/>
-
-            <com.google.android.material.checkbox.MaterialCheckBox
-                android:id="@+id/share_process_allow_resharing_checkbox"
-                android:layout_width="match_parent"
-                android:layout_height="wrap_content"
-                android:minHeight="@dimen/minimum_size_for_touchable_area"
-                android:text="@string/allow_resharing"
-                android:visibility="gone"
-                tools:visibility="visible" />
-
             <LinearLayout
                 android:id="@+id/custom_permission_layout"
                 tools:visibility="visible"

app/src/main/res/values/strings.xml

@@ -1170,7 +1170,6 @@
     <string name="share_permission_file_drop">File drop</string>
     <string name="share_permission_secure_file_drop">Secure file drop</string>
     <string name="share_permissions">Share permissions</string>
-    <string name="advanced_settings">Advanced settings</string>
     <string name="common_next">Next</string>
     <string name="send_share">Send share</string>
     <string name="no_share_permission_selected">Please select at least one permission to share.</string>