Commit aaff1df
Fixing timing issue with FileActivity's loading dialog show and dismiss.
Before dismissing the dialog, we need to wait for a potentially pending
transaction. As showing the dialog also includes the dismissing of prior
instances, we need to wait there as well.
Both is needed to satisfy the test case added in the previous commit.
Otherwise, the dialog might be shown after it was meant to be dismissed
already. This issue was observed when testing RemoveFilesDialogFragment's
removeFiles() and also sporadically "in the wild".
Signed-off-by: Philipp Hasper <vcs@hasper.info>1 parent b270821 commit aaff1df
1 file changed
Lines changed: 2 additions & 0 deletions
Lines changed: 2 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
563 | 563 | | |
564 | 564 | | |
565 | 565 | | |
| 566 | + | |
566 | 567 | | |
567 | 568 | | |
568 | 569 | | |
| |||
585 | 586 | | |
586 | 587 | | |
587 | 588 | | |
| 589 | + | |
588 | 590 | | |
589 | 591 | | |
590 | 592 | | |
| |||
0 commit comments